From 9cb21155b4376332f990f63fc0be8b421b7877e4 Mon Sep 17 00:00:00 2001 From: Yam ZhengLim Date: Fri, 30 Jun 2023 03:37:16 +0000 Subject: [PATCH] Debug daily_orders and company_conversion --- ...rep_exchange__company_conversion_funnels.sql | 17 ++++++++++------- .../reporting/rep_exchange__daily_orders.sql | 2 +- 2 files changed, 11 insertions(+), 8 deletions(-) diff --git a/models/marts/reporting/rep_exchange__company_conversion_funnels.sql b/models/marts/reporting/rep_exchange__company_conversion_funnels.sql index 1b28f75..9ef375f 100644 --- a/models/marts/reporting/rep_exchange__company_conversion_funnels.sql +++ b/models/marts/reporting/rep_exchange__company_conversion_funnels.sql @@ -192,7 +192,7 @@ identity_document_verified_activities AS ( FROM company_identity_documents WHERE - identity_status = '2' + identity_status = 'APPROVED' GROUP BY company_id @@ -316,7 +316,8 @@ union_all_activities_flag_migrated_company AS ( ), -get_number_of_conversions AS ( +-- This cumulative count is use for showing date to date conversion +generate_cumulative_count AS ( SELECT company_id, is_data_cleansing_generate_row, @@ -357,11 +358,11 @@ final__rep_exchange__company_conversion_funnels AS ( company_id, -- dimensions + is_data_cleansing_generate_row, + is_migrated_company, activity, activtity_rank, is_company_latest_activity, - is_data_cleansing_generate_row, - is_migrated_company, -- measures cumulative_register_activity, @@ -376,6 +377,7 @@ final__rep_exchange__company_conversion_funnels AS ( include_migrated_cumulative_register_activity, include_migrated_cumulative_email_verified_activity, include_migrated_cumulative_identity_document_uploaded_activity, + include_migrated_cumulative_identity_document_verified_activity, include_migrated_cumulative_first_time_booking_activity, include_migrated_cumulative_first_time_order_activity, include_migrated_cumulative_first_time_order_completed_activity, @@ -387,8 +389,9 @@ final__rep_exchange__company_conversion_funnels AS ( -- metadata _dbt_ran_datetime - - FROM get_number_of_conversions + + FROM generate_cumulative_count ) -SELECT * FROM final__rep_exchange__company_conversion_funnels \ No newline at end of file + +SELECT * FROM rep_exchange__company_conversion_funnels \ No newline at end of file diff --git a/models/marts/reporting/rep_exchange__daily_orders.sql b/models/marts/reporting/rep_exchange__daily_orders.sql index e2200bb..33ad7e3 100644 --- a/models/marts/reporting/rep_exchange__daily_orders.sql +++ b/models/marts/reporting/rep_exchange__daily_orders.sql @@ -135,7 +135,7 @@ fct_and_dim_joins AS ( FROM bookings - LEFT JOIN transaction_orders_get_next_order_created_datetime + RIGHT JOIN transaction_orders_get_next_order_created_datetime ON (bookings.booking_id = transaction_orders_get_next_order_created_datetime.booking_id) LEFT JOIN transaction_costs