From 00994d6ac141bcc340b08db3a407906338a58a27 Mon Sep 17 00:00:00 2001 From: Farhan Date: Tue, 26 Jul 2022 17:31:07 +0800 Subject: [PATCH] Add Label section on Settings Update create section api to support type --- .../ControllersLogic/CreateSegmentLogic.php | 2 +- .../Segments/Services/CreatesSegment.php | 3 +- .../settings/elements/SegmentComponent.vue | 16 ++++- .../settings/forms/SegmentFormComponent.vue | 33 ++++++++-- resources/views/pages/settings.blade.php | 63 ++++++++++++++++++- 5 files changed, 105 insertions(+), 12 deletions(-) diff --git a/app/Classes/Modules/Segments/ControllersLogic/CreateSegmentLogic.php b/app/Classes/Modules/Segments/ControllersLogic/CreateSegmentLogic.php index 32eeb217..f00f8996 100644 --- a/app/Classes/Modules/Segments/ControllersLogic/CreateSegmentLogic.php +++ b/app/Classes/Modules/Segments/ControllersLogic/CreateSegmentLogic.php @@ -54,7 +54,7 @@ class CreateSegmentLogic extends AbstractControllerLogic */ public function logic(Request $request) : JsonResponse { - $segment_object = new SegmentObject($request->input('name')); + $segment_object = new SegmentObject($request->input('name'), $request->input('type') ?? 2); $this->canCreateSegment->passes($segment_object); $segment = $this->createsSegment->execute($segment_object); diff --git a/app/Classes/Modules/Segments/Services/CreatesSegment.php b/app/Classes/Modules/Segments/Services/CreatesSegment.php index b18a8db5..0c2491d9 100644 --- a/app/Classes/Modules/Segments/Services/CreatesSegment.php +++ b/app/Classes/Modules/Segments/Services/CreatesSegment.php @@ -4,7 +4,6 @@ namespace App\Classes\Modules\Segments\Services; use App\Classes\General\Eloquent\AbstractUpdateRecord; use App\Classes\Modules\Segments\DataTransferObjects\SegmentObject; -use App\Classes\ValueObjects\Constants\SegmentConstants; use App\Models\Segment; class CreatesSegment extends AbstractUpdateRecord @@ -17,7 +16,7 @@ class CreatesSegment extends AbstractUpdateRecord public function execute(SegmentObject $object) { $model = new Segment(); $model->name = $object->getName(); - $model->type = SegmentConstants::CUSTOM_SEGMENT; + $model->type = $object->getType(); return $this->handler($model); diff --git a/resources/assets/vue/components/settings/elements/SegmentComponent.vue b/resources/assets/vue/components/settings/elements/SegmentComponent.vue index 54dafd09..ec865e23 100644 --- a/resources/assets/vue/components/settings/elements/SegmentComponent.vue +++ b/resources/assets/vue/components/settings/elements/SegmentComponent.vue @@ -1,5 +1,5 @@