From 2091553d7b11cedec00b5ac12dfd809adf218ee4 Mon Sep 17 00:00:00 2001
From: Dillon <dillonngoweijoon@gmail.com>
Date: Mon, 19 Jun 2023 06:28:25 +0800
Subject: [PATCH] Debug duplicated task created

---
 .../PerfexCRM/Processors/UpdatePerfexCRMProcessor.php     | 8 ++++++--
 .../Modules/PerfexCRM/Services/CreatesPerfexCRMTask.php   | 4 ----
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/app/Classes/Modules/PerfexCRM/Processors/UpdatePerfexCRMProcessor.php b/app/Classes/Modules/PerfexCRM/Processors/UpdatePerfexCRMProcessor.php
index a35debae..8798d7fd 100644
--- a/app/Classes/Modules/PerfexCRM/Processors/UpdatePerfexCRMProcessor.php
+++ b/app/Classes/Modules/PerfexCRM/Processors/UpdatePerfexCRMProcessor.php
@@ -203,7 +203,11 @@ class UpdatePerfexCRMProcessor
                 }
 
                 // Get existing or create task
-                $result = $this->fetchesPerfexCRMTask->execute($tasks[$count]['name'], $milestoneId, 'project', $projectId, $updatePerfexCRMObject->getInvoiceId());
+                $taskName = $tasks[$count]['name'];;
+                if($updatePerfexCRMObject->getInvoiceId() != 0){
+                    $taskName = $taskName." (".$updatePerfexCRMObject->getInvoiceId().")";
+                }
+                $result = $this->fetchesPerfexCRMTask->execute($taskName, $milestoneId, 'project', $projectId, $updatePerfexCRMObject->getInvoiceId());
                 Log::info("UpdatePerfexCRMProcessor task: ".json_encode($taskStatus)." , ".json_encode($result));
 
                 if(isset($result->payload)){
@@ -215,7 +219,7 @@ class UpdatePerfexCRMProcessor
                     }
                 }
                 else{
-                    $result = $this->createsPerfexCRMTask->execute($tasks[$count]['name'], $tasks[$count]['description'], '', $milestoneId, $projectId, $tasks[$count]['reference'], $tasks[$count]['on_task_completion'], $tasks[$count]['department'], $taskStatus, $tasks[$count]['priority'], $tasks[$count]['duedate'], $updatePerfexCRMObject->getInvoiceId());
+                    $result = $this->createsPerfexCRMTask->execute($taskName, $tasks[$count]['description'], '', $milestoneId, $projectId, $tasks[$count]['reference'], $tasks[$count]['on_task_completion'], $tasks[$count]['department'], $taskStatus, $tasks[$count]['priority'], $tasks[$count]['duedate'], $updatePerfexCRMObject->getInvoiceId());
                 }
 
                 //cief todo: to evaluate if this is still needed
diff --git a/app/Classes/Modules/PerfexCRM/Services/CreatesPerfexCRMTask.php b/app/Classes/Modules/PerfexCRM/Services/CreatesPerfexCRMTask.php
index 06ca013c..ace2aa00 100644
--- a/app/Classes/Modules/PerfexCRM/Services/CreatesPerfexCRMTask.php
+++ b/app/Classes/Modules/PerfexCRM/Services/CreatesPerfexCRMTask.php
@@ -36,10 +36,6 @@ class CreatesPerfexCRMTask
                 ];
             }
 
-            if($invoiceId != 0){
-                $taskName = $taskName." (".$invoiceId.")";
-            }
-
             $data = [
                 'name' => $taskName,
                 'description' => $taskDescription,