From bd7fd92cf0920f788d159e947c753c99667b38da Mon Sep 17 00:00:00 2001 From: Dillon Ngo Date: Sun, 24 Mar 2024 20:14:38 +0800 Subject: [PATCH] Laravel Vapor - Delete comments --- app/Classes/Jobs/ListDocumentsJob.php | 11 ----------- .../Accounts/Processors/AuthenticationProcessor.php | 2 +- .../Addresses/ControllersLogic/CreateAddressLogic.php | 2 +- .../Banks/ControllersLogic/CreateBankLogic.php | 2 +- .../Bookings/ControllersLogic/CreateBookingLogic.php | 2 +- .../ControllersLogic/AssignCompanyToSegmentLogic.php | 2 +- .../CreateIdentificationDocumentLogic.php | 2 +- app/Http/Controllers/AWS/AWSImageUploadController.php | 2 +- app/Http/Resources/CompanyResource.php | 4 ---- 9 files changed, 7 insertions(+), 22 deletions(-) diff --git a/app/Classes/Jobs/ListDocumentsJob.php b/app/Classes/Jobs/ListDocumentsJob.php index 6e93062b..25247c50 100644 --- a/app/Classes/Jobs/ListDocumentsJob.php +++ b/app/Classes/Jobs/ListDocumentsJob.php @@ -44,17 +44,6 @@ class ListDocumentsJob implements ShouldQueue } $result = (App()->make(ListDocumentsJobProcessor::class))->execute($this->listGenericJobObject); - - //cief todo: Insert into DB: job id, query result, timestamp - // Store the result in the job_results table - - //cief todo: why cannot save data in table like this - // $model = new JobResult(); - // $model->job_id = $this->job->getJobId(); - // $model->result = json_encode($result); - // $model->save(); - - // Log::error(json_encode($model->id)); } public function getJobId(){ diff --git a/app/Classes/Modules/Accounts/Processors/AuthenticationProcessor.php b/app/Classes/Modules/Accounts/Processors/AuthenticationProcessor.php index 707369e9..952bebdd 100644 --- a/app/Classes/Modules/Accounts/Processors/AuthenticationProcessor.php +++ b/app/Classes/Modules/Accounts/Processors/AuthenticationProcessor.php @@ -81,7 +81,7 @@ class AuthenticationProcessor $this->newCustomerToVoucherifyProcessor->execute(0, $user, false); } - //cief todo: case study 1 + //cief todo: case study 1 voucherify //$this->checkMilestonesForRewardProcessor->execute($user, [Milestones::MILESTONE_1]); return ['access_token' => $this->generatesAuthenticationToken->execute($user), 'redirect_url' => $this->authenticationRedirect->url($user)]; diff --git a/app/Classes/Modules/Addresses/ControllersLogic/CreateAddressLogic.php b/app/Classes/Modules/Addresses/ControllersLogic/CreateAddressLogic.php index a760254f..9c5bc602 100644 --- a/app/Classes/Modules/Addresses/ControllersLogic/CreateAddressLogic.php +++ b/app/Classes/Modules/Addresses/ControllersLogic/CreateAddressLogic.php @@ -81,7 +81,7 @@ class CreateAddressLogic extends AbstractControllerLogic $company = $this->fetchesCompany->execute(['id' => $request->input('company_id')]); $query = $this->createsAddress->execute($company, $object); - //cief todo: case study 6 + //cief todo: case study 6 voucherify // $user = $company->employees()->first(); // $this->checkMilestonesForRewardProcessor->execute($user, [Milestones::MILESTONE_6]); diff --git a/app/Classes/Modules/Banks/ControllersLogic/CreateBankLogic.php b/app/Classes/Modules/Banks/ControllersLogic/CreateBankLogic.php index bb9a3468..7d340b74 100644 --- a/app/Classes/Modules/Banks/ControllersLogic/CreateBankLogic.php +++ b/app/Classes/Modules/Banks/ControllersLogic/CreateBankLogic.php @@ -89,7 +89,7 @@ class CreateBankLogic extends AbstractControllerLogic // $bankLog = $this->createsBankLog->execute($bank); - //cief todo: case study 4 + //cief todo: case study 4 voucherify // $company = $this->fetchesCompany->execute(['id' => $request->input('company_id')]); // $user = $company->employees()->first(); // $this->checkMilestonesForRewardProcessor->execute($user, [Milestones::MILESTONE_4]); diff --git a/app/Classes/Modules/Bookings/ControllersLogic/CreateBookingLogic.php b/app/Classes/Modules/Bookings/ControllersLogic/CreateBookingLogic.php index 61f78dcb..9c13a015 100644 --- a/app/Classes/Modules/Bookings/ControllersLogic/CreateBookingLogic.php +++ b/app/Classes/Modules/Bookings/ControllersLogic/CreateBookingLogic.php @@ -97,7 +97,7 @@ class CreateBookingLogic extends AbstractControllerLogic $this->bookingToPerfexCRMProcessor->execute($booking); } - //cief todo: case study 5 + //cief todo: case study 5 voucherify // $user = $company->employees()->first(); // $this->checkMilestonesForRewardProcessor->execute($user, [Milestones::MILESTONE_5]); diff --git a/app/Classes/Modules/Companies/ControllersLogic/AssignCompanyToSegmentLogic.php b/app/Classes/Modules/Companies/ControllersLogic/AssignCompanyToSegmentLogic.php index 1148a6d6..3e8d0110 100644 --- a/app/Classes/Modules/Companies/ControllersLogic/AssignCompanyToSegmentLogic.php +++ b/app/Classes/Modules/Companies/ControllersLogic/AssignCompanyToSegmentLogic.php @@ -88,7 +88,7 @@ class AssignCompanyToSegmentLogic extends AbstractControllerLogic $this->createsSeasonalSegment->execute($seasonalSegmentObject); } - //cief todo: case study 3 + //cief todo: case study 3 voucherify // $user = $company->employees()->first(); // $this->checkMilestonesForRewardProcessor->execute($user, [Milestones::MILESTONE_3]); diff --git a/app/Classes/Modules/Companies/ControllersLogic/CreateIdentificationDocumentLogic.php b/app/Classes/Modules/Companies/ControllersLogic/CreateIdentificationDocumentLogic.php index 6a818ea8..5e1c331d 100644 --- a/app/Classes/Modules/Companies/ControllersLogic/CreateIdentificationDocumentLogic.php +++ b/app/Classes/Modules/Companies/ControllersLogic/CreateIdentificationDocumentLogic.php @@ -94,7 +94,7 @@ class CreateIdentificationDocumentLogic extends AbstractControllerLogic $this->newLeadTaskToPerfexCRMProcessor->execute($company); } - //cief todo: case study 2 + //cief todo: case study 2 voucherify // $user = $company->employees()->first(); // $this->checkMilestonesForRewardProcessor->execute($user, [Milestones::MILESTONE_2]); diff --git a/app/Http/Controllers/AWS/AWSImageUploadController.php b/app/Http/Controllers/AWS/AWSImageUploadController.php index f034b3a1..b0929c06 100644 --- a/app/Http/Controllers/AWS/AWSImageUploadController.php +++ b/app/Http/Controllers/AWS/AWSImageUploadController.php @@ -29,7 +29,7 @@ class AWSImageUploadController extends Controller $request->image->storeAs('images', $imageName); - //cief todo: checking if storage disk exist + //checking if storage disk exist if (Storage::disk('documents')) { $check1 = "The disk documents exists."; } else { diff --git a/app/Http/Resources/CompanyResource.php b/app/Http/Resources/CompanyResource.php index 55043f85..59eb3cee 100644 --- a/app/Http/Resources/CompanyResource.php +++ b/app/Http/Resources/CompanyResource.php @@ -52,10 +52,6 @@ class CompanyResource extends JsonResource $userInfoType = Auth::user()->type; } - //cief todo: remove - // Log::error('CompanyResource 1: '. json_encode($userInfoEmail)); - // Log::error('CompanyResource 2: '. json_encode($userInfoType)); - if(!is_null($userInfoEmail) && !is_null($userInfoType)){ $userResource = new UserResource($userInfoType === RoleTypes::USER ? $this->employees()->where('email', '=', $userInfoEmail)->first() : $this->employees()->orderBy('id', 'DESC')->first()); }