From b09308d9698a99133b46d8f3bb7e4b0307bed39e Mon Sep 17 00:00:00 2001 From: edmondlang Date: Sat, 29 Apr 2023 01:27:54 +0800 Subject: [PATCH] test appprove group mapping transaction api --- ...DuplicateBankStatementDetailsStatusLogic.php | 17 ++++++----------- .../UpdateStatementTransactionStatusLogic.php | 15 ++++++++------- 2 files changed, 14 insertions(+), 18 deletions(-) diff --git a/app/Classes/Modules/Accounting/ControllersLogic/ApproveDuplicateBankStatementDetailsStatusLogic.php b/app/Classes/Modules/Accounting/ControllersLogic/ApproveDuplicateBankStatementDetailsStatusLogic.php index 2edebfb6..8e2cb932 100644 --- a/app/Classes/Modules/Accounting/ControllersLogic/ApproveDuplicateBankStatementDetailsStatusLogic.php +++ b/app/Classes/Modules/Accounting/ControllersLogic/ApproveDuplicateBankStatementDetailsStatusLogic.php @@ -73,17 +73,12 @@ class ApproveDuplicateBankStatementDetailsStatusLogic extends AbstractController $this->updatesBankStatementTransactionOwnerStatus->execute($bankSatementDetails, ApprovalStatus::APPROVED); - dump($bankSatementDetails); - - dd($bankSatementDetails->transaction); - - if ($bankSatementDetails->owner) { - if ($bankSatementDetails->owner->type === StatementTransactionOwnerType::SALES) { - if ($bankSatementDetails->owner->status === ApprovalStatus::PENDING_VERIFICATION) { - $this->updatesTransactionStatus->execute($bankSatementDetails->owner, ApprovalStatus::APPROVED); - } - } - } + // todo-new: approve payments status, need to check the owner(if system is shipping, need to api with shipping portal) + // if ($bankSatementDetails->transaction->type === StatementTransactionOwnerType::SALES) { + // if ($bankSatementDetails->owner->status === ApprovalStatus::PENDING_VERIFICATION) { + // $this->updatesTransactionStatus->execute($bankSatementDetails->owner, ApprovalStatus::APPROVED); + // } + // } $rejectedBankSatementDetails = $this->listsBankStatementDetails->execute(['id_not' => $request->route('id'), 'owner_id' => $bankSatementDetails->owner_id]); diff --git a/app/Classes/Modules/Accounting/ControllersLogic/UpdateStatementTransactionStatusLogic.php b/app/Classes/Modules/Accounting/ControllersLogic/UpdateStatementTransactionStatusLogic.php index 29f3e6f6..3a006e9e 100644 --- a/app/Classes/Modules/Accounting/ControllersLogic/UpdateStatementTransactionStatusLogic.php +++ b/app/Classes/Modules/Accounting/ControllersLogic/UpdateStatementTransactionStatusLogic.php @@ -67,13 +67,14 @@ class UpdateStatementTransactionStatusLogic extends AbstractControllerLogic $this->updatesBankStatementTransactionOwnerStatus->execute($statementTrasactionOwner, $request->route('status') == 'approve' ? ApprovalStatus::APPROVED : ApprovalStatus::REJECTED); - if ($request->route('status') == 'approve') { - if ($statementTrasactionOwner->owner->type === StatementTransactionOwnerType::SALES) { - if ($statementTrasactionOwner->owner->status === ApprovalStatus::PENDING_VERIFICATION) { - $this->updatesTransactionStatus->execute($statementTrasactionOwner->owner, ApprovalStatus::APPROVED); - } - } - } + // todo-new: approve payments status, need to check the owner(if system is shipping, need to api with shipping portal) + // if ($request->route('status') == 'approve') { + // if ($statementTrasactionOwner->transaction->type === StatementTransactionOwnerType::SALES) { + // if ($statementTrasactionOwner->owner->status === ApprovalStatus::PENDING_VERIFICATION) { + // $this->updatesTransactionStatus->execute($statementTrasactionOwner->owner, ApprovalStatus::APPROVED); + // } + // } + // } return $this->resourceResponse(new BankStatementTransactionResource($statementTrasaction)); }