From e83db6a57f09bdec909fd92c050e748632c9e99b Mon Sep 17 00:00:00 2001 From: Dillon Ngo Date: Thu, 24 Oct 2024 03:09:12 +0800 Subject: [PATCH] Laravel Vapor - Fix inconsistency of download triggers which suppose to open in a new tab instead of current --- .../accounting/elements/HistoryImportedInvoices.vue | 4 +++- .../vue/components/bookings/elements/BillingComponent.vue | 1 - .../bookings/elements/UploadDebtorExcelComponent.vue | 4 +++- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/resources/assets/vue/components/accounting/elements/HistoryImportedInvoices.vue b/resources/assets/vue/components/accounting/elements/HistoryImportedInvoices.vue index d0dd1e93..23a8e1b4 100644 --- a/resources/assets/vue/components/accounting/elements/HistoryImportedInvoices.vue +++ b/resources/assets/vue/components/accounting/elements/HistoryImportedInvoices.vue @@ -41,7 +41,9 @@ successHandler(response) { if(window.LARAVEL_VAPOR_ENABLED){ if (response.src) { - window.location.href = response.src; + // window.location.href = response.src; + console.log('download'); + window.open(response.src, '_blank'); } } }, diff --git a/resources/assets/vue/components/bookings/elements/BillingComponent.vue b/resources/assets/vue/components/bookings/elements/BillingComponent.vue index c1700e32..3f8df642 100644 --- a/resources/assets/vue/components/bookings/elements/BillingComponent.vue +++ b/resources/assets/vue/components/bookings/elements/BillingComponent.vue @@ -127,7 +127,6 @@ export default { if(window.LARAVEL_VAPOR_ENABLED){ if (response.src) { // window.location.href = response.src; - console.log('download'); window.open(response.src, '_blank'); } } diff --git a/resources/assets/vue/components/bookings/elements/UploadDebtorExcelComponent.vue b/resources/assets/vue/components/bookings/elements/UploadDebtorExcelComponent.vue index 85db0263..2aa32607 100644 --- a/resources/assets/vue/components/bookings/elements/UploadDebtorExcelComponent.vue +++ b/resources/assets/vue/components/bookings/elements/UploadDebtorExcelComponent.vue @@ -81,7 +81,9 @@ response.json().then(response => { if(!success){return;} if (response.src) { - window.location.href = response.src; + // window.location.href = response.src; + console.log('download'); + window.open(response.src, '_blank'); } }); }