From c0c5f2ba24db775deb9fa5fecd469c1e3d0d4dbf Mon Sep 17 00:00:00 2001
From: omair saleh <uldvstar@gmail.com>
Date: Wed, 2 Mar 2022 04:10:30 +0800
Subject: [PATCH] download billing documents

---
 .../DownloadBookingDocumentLogic.php                 | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/app/Classes/Modules/Bookings/ControllersLogic/DownloadBookingDocumentLogic.php b/app/Classes/Modules/Bookings/ControllersLogic/DownloadBookingDocumentLogic.php
index ca240cf3..2cb0b7f1 100644
--- a/app/Classes/Modules/Bookings/ControllersLogic/DownloadBookingDocumentLogic.php
+++ b/app/Classes/Modules/Bookings/ControllersLogic/DownloadBookingDocumentLogic.php
@@ -3,6 +3,7 @@
 namespace App\Classes\Modules\Bookings\ControllersLogic;
 
 
+use Illuminate\Support\Facades\Response;
 use ZipArchive;
 use Carbon\Carbon;
 use App\Models\User;
@@ -23,7 +24,7 @@ class DownloadBookingDocumentLogic
 
     /**
      * @param Request $request
-     * @return void
+     * @return \Symfony\Component\HttpFoundation\BinaryFileResponse
      * @throws MalformedRequestException
      */
     public function execute(Request $request)
@@ -47,14 +48,9 @@ class DownloadBookingDocumentLogic
                 $zip->addFile(Storage::disk('documents')->path($file->file->file_info->original->file), $booking->created_at->format('d_m_Y') . '_' . $booking->marking . '.pdf');
             }
 
-            if ($zip->close() === false) {
-                exit("Error creating ZIP file");
-            };
-
-//            Storage::download($attachment);
-            File::get($attachment);
-            File::delete($attachment);
+            $zip->close();
 
+            return Response::download(File::get($attachment), $request->input('type').'.zip', ['Content-Type: application/zip']);
 
         }
     }