diff --git a/app/Classes/Jobs/UpdatePerfexCRM.php b/app/Classes/Jobs/UpdatePerfexCRM.php index acd1705a..7d4ce9b8 100644 --- a/app/Classes/Jobs/UpdatePerfexCRM.php +++ b/app/Classes/Jobs/UpdatePerfexCRM.php @@ -20,7 +20,7 @@ class UpdatePerfexCRM implements ShouldQueue /** @var UpdatePerfexCRMObject */ private $updatePerfexCRMObject; - /** @var Transaction */ + /** @var */ private $transaction; /** @var Boolean */ @@ -28,10 +28,10 @@ class UpdatePerfexCRM implements ShouldQueue /** * @param UpdatePerfexCRMObject $updatePerfexCRMObject - * @param Transaction $transaction + * @param $transaction * @param Boolean $shouldCreateInvoice */ - public function __construct(UpdatePerfexCRMObject $updatePerfexCRMObject, Transaction $transaction, Boolean $shouldCreateInvoice) + public function __construct(UpdatePerfexCRMObject $updatePerfexCRMObject, $transaction, Boolean $shouldCreateInvoice) { $this->updatePerfexCRMObject = $updatePerfexCRMObject; $this->transaction = $transaction; @@ -42,7 +42,7 @@ class UpdatePerfexCRM implements ShouldQueue public function handle() { $result = (App()->make(UpdatePerfexCRMProcessor::class))->execute($this->updatePerfexCRMObject); - if($this->transaction != null){ + if($this->transaction != null && $this->shouldCreateInvoice){ $updatePerfexCRMInvoiceObject = new UpdatePerfexCRMInvoiceObject( $this->updatePerfexCRMObject->getContactEmail(), $this->updatePerfexCRMObject->getProjectName(), @@ -51,9 +51,8 @@ class UpdatePerfexCRM implements ShouldQueue true ); - if($this->shouldCreateInvoice) { - UpdatePerfexCRMInvoice::dispatch($updatePerfexCRMInvoiceObject); - } + UpdatePerfexCRMInvoice::dispatch($updatePerfexCRMInvoiceObject); + } } }