From efed8b639d2d4feff3000a683bdf9857fa3a7ddf Mon Sep 17 00:00:00 2001 From: Dillon Ngo Date: Thu, 24 Oct 2024 03:38:53 +0800 Subject: [PATCH] Laravel Vapor - Fix inconsistency of download triggers which suppose to open in a new tab instead of current --- .../components/accounting/elements/HistoryImportedInvoices.vue | 1 - .../elements/CustomerTransactionHistorySectionComponent.vue | 1 - .../components/bookings/elements/UploadDebtorExcelComponent.vue | 1 - .../bookings/forms/SupplierPlaceOrderFormComponent.vue | 2 +- 4 files changed, 1 insertion(+), 4 deletions(-) diff --git a/resources/assets/vue/components/accounting/elements/HistoryImportedInvoices.vue b/resources/assets/vue/components/accounting/elements/HistoryImportedInvoices.vue index 23a8e1b4..b10721ee 100644 --- a/resources/assets/vue/components/accounting/elements/HistoryImportedInvoices.vue +++ b/resources/assets/vue/components/accounting/elements/HistoryImportedInvoices.vue @@ -42,7 +42,6 @@ if(window.LARAVEL_VAPOR_ENABLED){ if (response.src) { // window.location.href = response.src; - console.log('download'); window.open(response.src, '_blank'); } } diff --git a/resources/assets/vue/components/bookings/elements/CustomerTransactionHistorySectionComponent.vue b/resources/assets/vue/components/bookings/elements/CustomerTransactionHistorySectionComponent.vue index b0643368..76d9d509 100644 --- a/resources/assets/vue/components/bookings/elements/CustomerTransactionHistorySectionComponent.vue +++ b/resources/assets/vue/components/bookings/elements/CustomerTransactionHistorySectionComponent.vue @@ -131,7 +131,6 @@ export default { if(!success){return;} if (response.src) { // window.location.href = response.src; - console.log('download'); window.open(response.src, '_blank'); } }); diff --git a/resources/assets/vue/components/bookings/elements/UploadDebtorExcelComponent.vue b/resources/assets/vue/components/bookings/elements/UploadDebtorExcelComponent.vue index 2aa32607..c999b81a 100644 --- a/resources/assets/vue/components/bookings/elements/UploadDebtorExcelComponent.vue +++ b/resources/assets/vue/components/bookings/elements/UploadDebtorExcelComponent.vue @@ -82,7 +82,6 @@ if(!success){return;} if (response.src) { // window.location.href = response.src; - console.log('download'); window.open(response.src, '_blank'); } }); diff --git a/resources/assets/vue/components/bookings/forms/SupplierPlaceOrderFormComponent.vue b/resources/assets/vue/components/bookings/forms/SupplierPlaceOrderFormComponent.vue index 8fdd1ce4..2607388b 100644 --- a/resources/assets/vue/components/bookings/forms/SupplierPlaceOrderFormComponent.vue +++ b/resources/assets/vue/components/bookings/forms/SupplierPlaceOrderFormComponent.vue @@ -159,7 +159,7 @@ response.json().then(response => { if(!success){return;} if (response.src) { - window.location.href = response.src; + window.open(response.src, '_blank'); } }); }