diff --git a/app/Classes/Modules/Transactions/ControllersLogic/CreateSupplierTransactionLogic.php b/app/Classes/Modules/Transactions/ControllersLogic/CreateSupplierTransactionLogic.php index 73f73d7d..01e18b40 100644 --- a/app/Classes/Modules/Transactions/ControllersLogic/CreateSupplierTransactionLogic.php +++ b/app/Classes/Modules/Transactions/ControllersLogic/CreateSupplierTransactionLogic.php @@ -102,9 +102,7 @@ class CreateSupplierTransactionLogic extends AbstractControllerLogic /** @var Transaction $payment */ $payment = $this->fetchesTransaction->execute(['id' => $payment['id']]); - if($payment->status !== ApprovalStatus::APPROVED) { - continue; - } + if($payment->status !== ApprovalStatus::APPROVED) continue; $this->updatesTransactionStatus->execute($payment, ApprovalStatus::COMPLETED); $billNumber = $this->generatesTransactionBillNumber->execute('SPLR-'); @@ -116,9 +114,7 @@ class CreateSupplierTransactionLogic extends AbstractControllerLogic $transactions[] = $this->createsTransaction->execute($payment->booking, $object); } - if(!count($transactions)){ - return $this->response([]); - } + if(!count($transactions)) return $this->response([]); $pdf = LaravelMpdf::loadView('pages.pdfs.currency_vendor_order', ['transactions' => $transactions, 'supplier' => $supplier]); diff --git a/app/Http/Resources/TransactionResource.php b/app/Http/Resources/TransactionResource.php index 587a6ed9..fc0dff73 100644 --- a/app/Http/Resources/TransactionResource.php +++ b/app/Http/Resources/TransactionResource.php @@ -16,9 +16,6 @@ class TransactionResource extends JsonResource */ public function toArray($request) { - if($this->booking === null) { - var_dump($this->booking_id); - } return [ 'id' => $this->id, 'booking' => new BookingResource($this->booking),