From bea5a2d24cbf293a4039ceba63630c8a5acc64ee Mon Sep 17 00:00:00 2001
From: Omair Saleh <uldvstar@gmail.com>
Date: Mon, 17 Jun 2019 11:04:21 +0800
Subject: [PATCH] large commit

---
 .../Orders/UpdateReceiveNoteLogic.php         | 56 +++++++------------
 .../ReceiveNote/CreatesReceiveNote.php        |  0
 ...teDate.php => UpdatesStepCompleteDate.php} | 19 ++++---
 3 files changed, 31 insertions(+), 44 deletions(-)
 delete mode 100644 app/Classes/Modules/Orders/Services/ReceiveNote/CreatesReceiveNote.php
 rename app/Classes/Modules/Orders/Services/Steps/{UpdatesOrderReceiveNoteDate.php => UpdatesStepCompleteDate.php} (76%)

diff --git a/app/Classes/Modules/ControllersLogic/Orders/UpdateReceiveNoteLogic.php b/app/Classes/Modules/ControllersLogic/Orders/UpdateReceiveNoteLogic.php
index 3f42442..3310c37 100644
--- a/app/Classes/Modules/ControllersLogic/Orders/UpdateReceiveNoteLogic.php
+++ b/app/Classes/Modules/ControllersLogic/Orders/UpdateReceiveNoteLogic.php
@@ -1,66 +1,52 @@
 <?php
-/**
- * Created by PhpStorm.
- * User: mhmj
- * Date: 27/05/2019
- * Time: 11:23 AM
- */
 
 namespace App\Classes\Modules\ControllersLogic\Orders;
 
+use App\Classes\Constants;
 use App\Classes\Modules\ControllerLogic\Exceptions\InternalServerErrorException;
 use App\Classes\Modules\Orders\DataTransferObjects\OrderObject;
-use App\Classes\Modules\Orders\DataTransferObjects\ReceiveNoteObject;
 use App\Classes\Modules\Orders\DataTransferObjects\StepObject;
-use App\Classes\Modules\Orders\Services\ReceiveNote\CreatesReceiveNote;
 use App\Classes\Modules\Orders\Services\SetsOrderWarehouse;
-use App\Classes\Modules\Orders\Services\Steps\UpdatesOrderReceiveNoteDate;
-use App\Models\Order;
+use App\Classes\Modules\Orders\Services\Steps\UpdatesStepCompleteDate;
+use App\Classes\ValueObjects\Constants\HttpStatus;
+use Illuminate\Http\JsonResponse;
 use Illuminate\Http\Request;
 
 class UpdateReceiveNoteLogic
 {
-    /** @var  Order */
-    private $repository;
-
-
     /** @var  SetsOrderWarehouse */
-    private $SetsOrderWarehouse;
+    private $setsOrderWarehouse;
 
-    /** @var  UpdatesOrderReceiveNoteDate */
-    private $UpdatesOrderReceiveNoteDate;
-
-    /** @var  CreatesReceiveNote */
-    private $CreatesReceiveNote;
+    /** @var  UpdatesStepCompleteDate */
+    private $updatesStepCompleteDate;
 
     /**
      * UpdateReceiveNoteLogic constructor.
-     * @param Order $repository
-     * @param SetsOrderWarehouse $SetsOrderWarehouse
-     * @param UpdatesOrderReceiveNoteDate $UpdatesOrderReceiveNoteDate
-     * @param CreatesReceiveNote $CreatesReceiveNote
+     * @param SetsOrderWarehouse $setsOrderWarehouse
+     * @param UpdatesStepCompleteDate $updatesStepCompleteDate
      */
-    public function __construct(Order $repository, SetsOrderWarehouse $SetsOrderWarehouse, UpdatesOrderReceiveNoteDate $UpdatesOrderReceiveNoteDate, CreatesReceiveNote $CreatesReceiveNote)
+    public function __construct(SetsOrderWarehouse $setsOrderWarehouse, UpdatesStepCompleteDate $updatesStepCompleteDate)
     {
-        $this->repository = $repository;
-        $this->SetsOrderWarehouse = $SetsOrderWarehouse;
-        $this->UpdatesOrderReceiveNoteDate = $UpdatesOrderReceiveNoteDate;
-        $this->CreatesReceiveNote = $CreatesReceiveNote;
+        $this->setsOrderWarehouse = $setsOrderWarehouse;
+        $this->updatesStepCompleteDate = $updatesStepCompleteDate;
     }
 
 
+    /**
+     * @param string $orderId
+     * @param Request $request
+     * @return JsonResponse
+     * @throws InternalServerErrorException
+     */
     public function execute(string $orderId, Request $request){
 
         try{
             $orderObject = new OrderObject($orderId, null, $request->input('warehouse_id'));
-            $this->SetsOrderWarehouse->execute($orderObject);
+            $this->setsOrderWarehouse->execute($orderObject);
 
-            $receiveNoteObject = new ReceiveNoteObject($request->input('tracking_no'));
-            $this->CreatesReceiveNote->execute($orderObject, $receiveNoteObject);
+            $stepObject = new StepObject(Constants::ORDER_WAREHOUSE_RECEIVING_STEP, $request->input('complete_date'));
+            $this->updatesStepCompleteDate->execute($orderObject, $stepObject);
 
-            $repository = $this->repository->findOrFail($orderId);
-            $stepObject = new StepObject($repository->current_step, $request->input('complete_date'));
-            return $this->UpdatesOrderReceiveNoteDate->execute($orderId, $stepObject);
 
             return new JsonResponse([], HttpStatus::RESOURCE_CREATED);
 
diff --git a/app/Classes/Modules/Orders/Services/ReceiveNote/CreatesReceiveNote.php b/app/Classes/Modules/Orders/Services/ReceiveNote/CreatesReceiveNote.php
deleted file mode 100644
index e69de29..0000000
diff --git a/app/Classes/Modules/Orders/Services/Steps/UpdatesOrderReceiveNoteDate.php b/app/Classes/Modules/Orders/Services/Steps/UpdatesStepCompleteDate.php
similarity index 76%
rename from app/Classes/Modules/Orders/Services/Steps/UpdatesOrderReceiveNoteDate.php
rename to app/Classes/Modules/Orders/Services/Steps/UpdatesStepCompleteDate.php
index cbfca31..9116ee7 100644
--- a/app/Classes/Modules/Orders/Services/Steps/UpdatesOrderReceiveNoteDate.php
+++ b/app/Classes/Modules/Orders/Services/Steps/UpdatesStepCompleteDate.php
@@ -1,20 +1,16 @@
 <?php
-/**
- * Created by PhpStorm.
- * User: mhmj
- * Date: 27/05/2019
- * Time: 12:01 PM
- */
 
 namespace App\Classes\Modules\Orders\Services\Steps;
 
 
 use App\Classes\Modules\ControllerLogic\Exceptions\InternalServerErrorException;
 use App\Classes\Modules\Orders\DataTransferObjects\StepObject;
+use App\Classes\ValueObjects\Constants\HttpStatus;
 use App\Models\OrderStep;
 use App\Http\Resources\OrderStep as OrderStepResources;
+use Illuminate\Http\JsonResponse;
 
-class UpdatesOrderReceiveNoteDate
+class UpdatesStepCompleteDate
 {
     /** @var  OrderStep */
     private $repository;
@@ -28,18 +24,23 @@ class UpdatesOrderReceiveNoteDate
         $this->repository = $repository;
     }
 
+    /**
+     * @param string $orderId
+     * @param StepObject $step
+     * @return JsonResponse
+     * @throws InternalServerErrorException
+     */
     public function execute(string $orderId, StepObject $step){
 
         try{
             $repository = $this->repository->where('order_id',$orderId)->where('reference_id',$step->getReferenceId())->first();
             $repository->complete_date = $step->getCompleteDate();
             $repository->save();
-            return $repository;
 
             return new JsonResponse([], HttpStatus::OK);
 
         } catch (\Exception $exception){
-            throw new InternalServerErrorException("Failed to update receive note because {$exception->getMessage()}");
+            throw new InternalServerErrorException("Failed to update step complete date because {$exception->getMessage()}");
         }