From 5df226c1530903bc134b3abdcf3a32e7ed0eec9f Mon Sep 17 00:00:00 2001 From: omair saleh Date: Thu, 7 Apr 2022 21:12:15 +0800 Subject: [PATCH] update final touch up for last delivery integration --- .../CreateDeliveryOrderLogic.php | 2 +- .../Orders/Services/GeneratesOrderNumber.php | 8 ++-- .../forms/DeliveryOrderFormComponent.vue | 37 +++++++++---------- 3 files changed, 24 insertions(+), 23 deletions(-) diff --git a/app/Classes/Modules/Delivery/ControllersLogic/CreateDeliveryOrderLogic.php b/app/Classes/Modules/Delivery/ControllersLogic/CreateDeliveryOrderLogic.php index 0c5af797..69ffcc55 100644 --- a/app/Classes/Modules/Delivery/ControllersLogic/CreateDeliveryOrderLogic.php +++ b/app/Classes/Modules/Delivery/ControllersLogic/CreateDeliveryOrderLogic.php @@ -121,7 +121,7 @@ class CreateDeliveryOrderLogic extends AbstractControllerLogic /** @var CompanyModule $companyModule */ $companyModule = $company->companyModules()->where('type', BusinessType::ONLINE_SELLER)->first(); - $orderObject = new OrderObject($this->generatesOrderNumber->execute(), OrderType::LAST_MILE_DELIVERY, ApprovalStatus::APPROVED); + $orderObject = new OrderObject($this->generatesOrderNumber->execute('168M', 7), OrderType::LAST_MILE_DELIVERY, ApprovalStatus::APPROVED); $this->canCreateOrder->passes($orderObject); diff --git a/app/Classes/Modules/Orders/Services/GeneratesOrderNumber.php b/app/Classes/Modules/Orders/Services/GeneratesOrderNumber.php index e1aa006e..49ae43fb 100644 --- a/app/Classes/Modules/Orders/Services/GeneratesOrderNumber.php +++ b/app/Classes/Modules/Orders/Services/GeneratesOrderNumber.php @@ -20,11 +20,13 @@ class GeneratesOrderNumber /** - * @return int + * @param null|string $prefix + * @param int|null $length + * @return string */ - public function execute(): int { + public function execute(?string $prefix = '', ?int $length = 9): string { - $reference = rand(100000001, 999999999); + $reference = $prefix.rand((int)('1'.str_repeat(0, $length - 2).'1'), (int) str_repeat(9, $length)); return !$this->checkIfOrderNumberExists->execute($reference) ? $reference : self::execute(); } diff --git a/resources/assets/vue/components/orders/forms/DeliveryOrderFormComponent.vue b/resources/assets/vue/components/orders/forms/DeliveryOrderFormComponent.vue index 96351c90..8b271ae3 100644 --- a/resources/assets/vue/components/orders/forms/DeliveryOrderFormComponent.vue +++ b/resources/assets/vue/components/orders/forms/DeliveryOrderFormComponent.vue @@ -11,20 +11,6 @@
-
-
-
-
- -
-
-
-
-
Walk In
-
-
-
-
@@ -39,6 +25,21 @@
+
+
+
Coming Soon
+
+
+ +
+
+
+
+
Walk In
+
+
+
+
@@ -301,7 +302,7 @@ step: 1, error: '', parameters : { - type: 0, + type: 1, sender_address_id: '', delivery_address_id: '', company_id: this.company.id, @@ -309,7 +310,7 @@ description: '', type: '0', value: 0.00, - weight: 0.0, + weight: 1.0, quantity: 1, } } @@ -318,9 +319,7 @@ validations: { parameters : { packing_list: { - description: { - required: required - }, + description: {}, type: { required: required },