From 65782ebf8a2e3227caeda6e60f8bf58953dfece1 Mon Sep 17 00:00:00 2001 From: Dillon Ngo Date: Thu, 14 Mar 2024 12:43:58 +0800 Subject: [PATCH] Long term solution to prevent customer making payment to a shipping invoice when there is a ongoing dispute --- .../Modules/Transactions/ControllersLogic/CreateGroupsLogic.php | 2 +- .../ControllersLogic/CreatePaymentTransactionLogic.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/Classes/Modules/Transactions/ControllersLogic/CreateGroupsLogic.php b/app/Classes/Modules/Transactions/ControllersLogic/CreateGroupsLogic.php index 2346554f..c750f3f2 100644 --- a/app/Classes/Modules/Transactions/ControllersLogic/CreateGroupsLogic.php +++ b/app/Classes/Modules/Transactions/ControllersLogic/CreateGroupsLogic.php @@ -89,7 +89,7 @@ class CreateGroupsLogic extends AbstractControllerLogic $invoices = Transaction::whereIn('id', $invoice_ids)->get(); $isInvoicesApprove = $this->checkIfInvoicesAreApprove($invoices); if(!$isInvoicesApprove){ - $response = ['message' => 'Transaction might be suspended, check if there is any dispute in progress.']; + $response = ['message' => 'One of the transactions might be suspended; please check if there are any disputes in progress.']; return $this->response(['data' => $response]); } else{ diff --git a/app/Classes/Modules/Transactions/ControllersLogic/CreatePaymentTransactionLogic.php b/app/Classes/Modules/Transactions/ControllersLogic/CreatePaymentTransactionLogic.php index 76fffd7a..c8c8d914 100644 --- a/app/Classes/Modules/Transactions/ControllersLogic/CreatePaymentTransactionLogic.php +++ b/app/Classes/Modules/Transactions/ControllersLogic/CreatePaymentTransactionLogic.php @@ -62,7 +62,7 @@ class CreatePaymentTransactionLogic extends AbstractControllerLogic return $this->resourceResponse(new TransactionResource($payment_transaction)); } - $response = ['message' => 'Transaction might be suspended, check if there is any dispute in progress.']; + $response = ['message' => 'A transaction might be suspended; please check if there is any dispute in progress.']; return $this->response(['data' => $response]); }