From 81474625eb565f31f67ff4a8f641e2edc6a32a81 Mon Sep 17 00:00:00 2001 From: Dillon Ngo Date: Tue, 16 Sep 2025 13:52:59 +0800 Subject: [PATCH] Remove redundant code --- .../RegenerateSingleStorageInvoiceTransactionLogic.php | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/app/Classes/Modules/Transactions/ControllersLogic/RegenerateSingleStorageInvoiceTransactionLogic.php b/app/Classes/Modules/Transactions/ControllersLogic/RegenerateSingleStorageInvoiceTransactionLogic.php index 02962362..f4694265 100644 --- a/app/Classes/Modules/Transactions/ControllersLogic/RegenerateSingleStorageInvoiceTransactionLogic.php +++ b/app/Classes/Modules/Transactions/ControllersLogic/RegenerateSingleStorageInvoiceTransactionLogic.php @@ -52,14 +52,7 @@ class RegenerateSingleStorageInvoiceTransactionLogic extends AbstractControllerL $invoice = $this->fetchesTransaction->execute(['id' => $request->route('invoice_id')]); $packingList = $invoice->owner; - $order = $packingList->owner; - $invoices = $order->transactions()->where('transactions.type', TransactionType::STORAGE_INVOICE)->get(); - - foreach ($invoices as $invoice){ - if($invoice->id === (int) $request->route('invoice_id')){ - $invoice->documents()->delete(); - } - } + $invoice->documents()->delete(); $this->createStorageInvoiceDocTransactionProcessor->execute($packingList, true); Log::info(Auth::user()->email." regenerate storage invoice for transaction with id ".$request->route('invoice_id'));