From 9518928b7d90e2eedb059aa0d64b9b92be8d80d4 Mon Sep 17 00:00:00 2001 From: Dillon Ngo Date: Tue, 12 Nov 2024 07:59:38 +0800 Subject: [PATCH 1/3] Laravel Vapor - Remove comments --- .../Transactions/Processors/ReleaseGoodsToCustomerProcessor.php | 1 - 1 file changed, 1 deletion(-) diff --git a/app/Classes/Modules/Transactions/Processors/ReleaseGoodsToCustomerProcessor.php b/app/Classes/Modules/Transactions/Processors/ReleaseGoodsToCustomerProcessor.php index bbf6a000..c00bad32 100644 --- a/app/Classes/Modules/Transactions/Processors/ReleaseGoodsToCustomerProcessor.php +++ b/app/Classes/Modules/Transactions/Processors/ReleaseGoodsToCustomerProcessor.php @@ -69,7 +69,6 @@ class ReleaseGoodsToCustomerProcessor Log::channel('storage_invoices')->info('ReleaseGoodsToCustomerProcessor updatesTransactionStatus'); $this->updatesTransactionStatus->execute($invoice, ApprovalStatus::COMPLETED); - //cief todo: remove the following if block if($invoice->type === TransactionType::STORAGE_INVOICE){ Log::channel('storage_invoices')->info('ReleaseGoodsToCustomerProcessor createStorageInvoiceDocTransactionProcessor'); $this->createStorageInvoiceDocTransactionProcessor->execute($packingList); From 2074c8661a8aa7e77bd717e873075605e1698bc8 Mon Sep 17 00:00:00 2001 From: Dillon Ngo Date: Tue, 12 Nov 2024 08:01:59 +0800 Subject: [PATCH 2/3] Laravel Vapor - Remove comments --- config/perfexcrm.php | 2 +- .../reports/sections/ServiceReportSectionPollingComponent.vue | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/config/perfexcrm.php b/config/perfexcrm.php index 4805c062..255a837b 100644 --- a/config/perfexcrm.php +++ b/config/perfexcrm.php @@ -1,7 +1,7 @@ env('PERFEXCRM_BASE_URL', 'http://192.168.1.100:8084'), //cief todo: Update crm api domain here + 'base_url' => env('PERFEXCRM_BASE_URL', 'http://192.168.1.100:8084'), 'api_key' => env('PERFEXCRM_API_KEY', ''), 'is_enabled' => env('PERFEXCRM_IS_ENABLED', 'true'), ]; diff --git a/resources/assets/vue/components/reports/sections/ServiceReportSectionPollingComponent.vue b/resources/assets/vue/components/reports/sections/ServiceReportSectionPollingComponent.vue index 6c67cf42..82c6b913 100644 --- a/resources/assets/vue/components/reports/sections/ServiceReportSectionPollingComponent.vue +++ b/resources/assets/vue/components/reports/sections/ServiceReportSectionPollingComponent.vue @@ -321,7 +321,6 @@ } }, errorHandler(error){ - // console.log("Error: " + JSON.stringify(error)); this.$store.dispatch('updatePollingJobResultByJobId', {'jobId': this.getJob.jobId, 'isPolling': false, 'isFetchingResult': false }); }, fetchJobResult(isLastAttempt = false) { From 67969c63d35a30d26ee17ef543fa355e9a83b642 Mon Sep 17 00:00:00 2001 From: Dillon Ngo Date: Tue, 12 Nov 2024 09:05:45 +0800 Subject: [PATCH 3/3] Laravel Vapor - Logs output minor amendments (code sync with Exchange) --- app/Classes/General/LogHelper.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/Classes/General/LogHelper.php b/app/Classes/General/LogHelper.php index ffea115c..f74725b5 100644 --- a/app/Classes/General/LogHelper.php +++ b/app/Classes/General/LogHelper.php @@ -19,7 +19,7 @@ class LogHelper { $envVar = env('LARAVEL_VAPOR_ENABLED'); $isLocal = env('VAPOR_ENV') === 'local'; - Log::info("LogHelper.info: {$message}, channelName: {$this->channelName}, envVar {$envVar}"); + Log::info("Info: {$message}, channelName: {$this->channelName}, envVar {$envVar}"); if ($envVar && !$isLocal) { Log::channel($this->channelName.'_vapor')->info($message); } @@ -32,7 +32,7 @@ class LogHelper { $envVar = env('LARAVEL_VAPOR_ENABLED'); $isLocal = env('VAPOR_ENV') === 'local'; - Log::info("LogHelper.warning: {$message}, channelName: {$this->channelName}, envVar {$envVar}"); + Log::info("Warning: {$message}, channelName: {$this->channelName}, envVar {$envVar}"); if ($envVar && !$isLocal) { Log::channel($this->channelName . '_vapor')->warning($message); } else { @@ -44,7 +44,7 @@ class LogHelper { $envVar = env('LARAVEL_VAPOR_ENABLED'); $isLocal = env('VAPOR_ENV') === 'local'; - Log::info("LogHelper.error: {$message}, channelName: {$this->channelName}, envVar {$envVar}"); + Log::info("Error: {$message}, channelName: {$this->channelName}, envVar {$envVar}"); if ($envVar && !$isLocal) { Log::channel($this->channelName . '_vapor')->error($message); } else {