From 8564667c6255ccf52b8b8e2925da20fa2eb41c45 Mon Sep 17 00:00:00 2001 From: Dillon Ngo Date: Tue, 5 Aug 2025 19:47:42 +0800 Subject: [PATCH] Fix a problem reported by Eileen where storage invoice has negative charges --- .../Processors/CheckStorageInvoiceTransactionProcessor.php | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/app/Classes/Modules/Transactions/Processors/CheckStorageInvoiceTransactionProcessor.php b/app/Classes/Modules/Transactions/Processors/CheckStorageInvoiceTransactionProcessor.php index 69025406..db660866 100644 --- a/app/Classes/Modules/Transactions/Processors/CheckStorageInvoiceTransactionProcessor.php +++ b/app/Classes/Modules/Transactions/Processors/CheckStorageInvoiceTransactionProcessor.php @@ -233,10 +233,15 @@ class CheckStorageInvoiceTransactionProcessor LogHelper::channel('storage_invoices')->info('eta: '.json_encode($eta)); LogHelper::channel('storage_invoices')->info('dt1: '.json_encode($dt1)); LogHelper::channel('storage_invoices')->info('dt2: '.json_encode($dt2)); + + //Goods should arrive first before checking for number of days stored + if ($dt1->greaterThan($dt2)) { + return null; + } + LogHelper::channel('storage_invoices')->info('interval: '.json_encode($interval)); LogHelper::channel('storage_invoices')->info('Carbon now: '.json_encode(Carbon::now())); - $resultNumberOfDaysExceeded = $interval->days - $resultNumberOfDaysFree; $storageInvoice = $destinationWarehousePackage->transactions()->where('transactions.type', TransactionType::STORAGE_INVOICE)->first(); $storageInvoiceId = 0;