From 6836e42ce40474201532f6ed2428b99dc2b013db Mon Sep 17 00:00:00 2001
From: edmondlang <edmond_wuiming@hotmail.com>
Date: Mon, 18 Apr 2022 00:16:10 +0800
Subject: [PATCH] tidy up update group controller logic

---
 .../ControllersLogic/UpdateGroupLogic.php     | 29 +++++--------------
 1 file changed, 8 insertions(+), 21 deletions(-)

diff --git a/app/Classes/Modules/Transactions/ControllersLogic/UpdateGroupLogic.php b/app/Classes/Modules/Transactions/ControllersLogic/UpdateGroupLogic.php
index 0f91042c..e353f06a 100644
--- a/app/Classes/Modules/Transactions/ControllersLogic/UpdateGroupLogic.php
+++ b/app/Classes/Modules/Transactions/ControllersLogic/UpdateGroupLogic.php
@@ -3,24 +3,21 @@
 namespace App\Classes\Modules\Transactions\ControllersLogic;
 
 use App\Classes\General\Abstracts\AbstractControllerLogic;
-use App\Classes\Modules\Transactions\Services\FetchesGroup;
-use App\Classes\Modules\Transactions\Services\DeletesTransaction;
-use App\Classes\Modules\Transactions\Services\updatesTransactionStatus;
-use App\Classes\ValueObjects\Constants\ApprovalStatus;
 use App\Http\Resources\GroupResource;
-use ErrorException;
-use Illuminate\Http\JsonResponse;
-use Illuminate\Http\Request;
 use App\Models\SegmentConstant;
-use App\Classes\ValueObjects\Constants\SegmentConstants;
 use App\Classes\Modules\Companies\Services\FetchesCompany;
 use App\Classes\Modules\Transactions\Services\CalculatesTransactionServiceCharge;
 use App\Classes\Modules\Transactions\DataTransferObjects\TransactionObject;
-use App\Classes\ValueObjects\Constants\TransactionType;
-use App\Classes\ValueObjects\Constants\PaymentMethodType;
+use App\Classes\Modules\Transactions\Services\FetchesGroup;
 use App\Classes\Modules\Transactions\Services\UpdatesTransaction;
 use App\Classes\Modules\Transactions\Services\CalculatesTransactionTransferFee;
-
+use App\Classes\ValueObjects\Constants\TransactionType;
+use App\Classes\ValueObjects\Constants\PaymentMethodType;
+use App\Classes\ValueObjects\Constants\SegmentConstants;
+use App\Classes\ValueObjects\Constants\ApprovalStatus;
+use Illuminate\Http\JsonResponse;
+use Illuminate\Http\Request;
+use ErrorException;
 
 class UpdateGroupLogic extends AbstractControllerLogic
 {
@@ -35,15 +32,9 @@ class UpdateGroupLogic extends AbstractControllerLogic
         ];
     }
 
-    /** @var UpdatesTransactionStatus */
-    private $updatesTransactionStatus;
-
     /** @var FetchesGroup */
     private $fetchesGroup;
 
-    /** @var DeletesTransaction */
-    private $deletesTransaction;
-
     /** @var FetchesCompany */
     private $fetchesCompany;
 
@@ -57,18 +48,14 @@ class UpdateGroupLogic extends AbstractControllerLogic
     private $calculatesTransactionTransferFee;
 
     public function __construct(
-        UpdatesTransactionStatus $updatesTransactionStatus, 
         FetchesGroup $fetchesGroup,
-        DeletesTransaction $deletesTransaction,
         FetchesCompany $fetchesCompany,
         CalculatesTransactionServiceCharge $calculatesTransactionServiceCharge,
         UpdatesTransaction $updatesTransaction,
         CalculatesTransactionTransferFee $calculatesTransactionTransferFee
     )
     {
-        $this->updatesTransactionStatus = $updatesTransactionStatus;
         $this->fetchesGroup = $fetchesGroup;
-        $this->deletesTransaction = $deletesTransaction;
         $this->fetchesCompany = $fetchesCompany;
         $this->calculatesTransactionServiceCharge = $calculatesTransactionServiceCharge;
         $this->updatesTransaction = $updatesTransaction;