From 1d3b8c2af76cc23e14ee2c5a16b06dcf04f4faa8 Mon Sep 17 00:00:00 2001 From: Jack Goh Date: Mon, 30 Jul 2018 13:49:35 +0800 Subject: [PATCH 1/5] temporary fix register page --- .../Controllers/Auth/RegisterController.php | 6 +++- resources/assets/js/pages/auth/register.vue | 30 +++++++++---------- 2 files changed, 20 insertions(+), 16 deletions(-) diff --git a/app/Http/Controllers/Auth/RegisterController.php b/app/Http/Controllers/Auth/RegisterController.php index e86685b1..95881ae5 100644 --- a/app/Http/Controllers/Auth/RegisterController.php +++ b/app/Http/Controllers/Auth/RegisterController.php @@ -46,7 +46,6 @@ class RegisterController extends Controller protected function validator(array $data) { return Validator::make($data, [ - 'name' => 'required|name|max:255', 'marking' => 'required|max:255|unique:markings', 'email' => 'required|email|max:255|unique:users', 'password' => 'required|min:6|confirmed', @@ -61,6 +60,11 @@ class RegisterController extends Controller */ protected function create(Request $data) { + $this->validate($data, [ + 'email' => 'required|email|max:255|unique:users', + 'password' => 'required|min:6|confirmed', + ]); + $marking = Marking::Where('email',$data['email'])->first(); if(!$marking){ diff --git a/resources/assets/js/pages/auth/register.vue b/resources/assets/js/pages/auth/register.vue index dc4dccd2..2e236c85 100644 --- a/resources/assets/js/pages/auth/register.vue +++ b/resources/assets/js/pages/auth/register.vue @@ -5,65 +5,65 @@
-
+
- + - {{ errors.first('marking') }}
+
-
+
- + - {{ errors.first('email') }} +
-
+
- + - + - {{ errors.first('password') }} +
-
+
- + - + - {{ errors.first('password_confirmation') }}
+
- + {{ $t('register') }} From cc2539d44cd86e2febbfed125153861cebe968ae Mon Sep 17 00:00:00 2001 From: Jack Goh Date: Mon, 30 Jul 2018 14:48:48 +0800 Subject: [PATCH 2/5] update max upload file size to 10mb --- app/Http/Controllers/BookingController.php | 6 +++--- app/Http/Controllers/ChinaBankSlipController.php | 2 +- resources/assets/js/pages/auth/register.vue | 3 +-- 3 files changed, 5 insertions(+), 6 deletions(-) diff --git a/app/Http/Controllers/BookingController.php b/app/Http/Controllers/BookingController.php index 844754e1..a18e9cf6 100644 --- a/app/Http/Controllers/BookingController.php +++ b/app/Http/Controllers/BookingController.php @@ -403,7 +403,7 @@ class BookingController extends Controller } $validator = Validator::make($request->all(), [ - 'file' => 'max:3072' + 'file' => 'max:10000' // image size ]); if($validator->fails()) @@ -497,7 +497,7 @@ class BookingController extends Controller } $validator = Validator::make($request->all(), [ - 'file' => 'max:3072' + 'file' => 'max:10000' ]); if($validator->fails()) @@ -767,7 +767,7 @@ class BookingController extends Controller } $validator = Validator::make($request->all(), [ - 'invoice_path' => 'max:3072' + 'invoice_path' => 'max:10000' ]); if($validator->fails()) diff --git a/app/Http/Controllers/ChinaBankSlipController.php b/app/Http/Controllers/ChinaBankSlipController.php index 58aad3a0..0ed406ed 100644 --- a/app/Http/Controllers/ChinaBankSlipController.php +++ b/app/Http/Controllers/ChinaBankSlipController.php @@ -32,7 +32,7 @@ class ChinaBankSlipController extends Controller } $validator = Validator::make($request->all(), [ - 'china_bank_slips' => 'max:3072' + 'china_bank_slips' => 'max:10000' ]); if($validator->fails()){ diff --git a/resources/assets/js/pages/auth/register.vue b/resources/assets/js/pages/auth/register.vue index 2e236c85..c6609c44 100644 --- a/resources/assets/js/pages/auth/register.vue +++ b/resources/assets/js/pages/auth/register.vue @@ -8,8 +8,7 @@
- - +
From 6dd391544b0a038b628db2be6e4ffc118ff8d643 Mon Sep 17 00:00:00 2001 From: Jack Goh Date: Mon, 30 Jul 2018 16:32:04 +0800 Subject: [PATCH 3/5] change account_num data type to string since have to allow user to enter space --- ...62106_change_datatype_in_booking_table.php | 33 +++++++++++++++++++ .../js/pages/booking/uploadUserBankSlip.vue | 1 + 2 files changed, 34 insertions(+) create mode 100644 database/migrations/2018_07_30_162106_change_datatype_in_booking_table.php diff --git a/database/migrations/2018_07_30_162106_change_datatype_in_booking_table.php b/database/migrations/2018_07_30_162106_change_datatype_in_booking_table.php new file mode 100644 index 00000000..fa2cb486 --- /dev/null +++ b/database/migrations/2018_07_30_162106_change_datatype_in_booking_table.php @@ -0,0 +1,33 @@ +string('account_num')->nullable()->change(); + + }); + } + + /** + * Reverse the migrations. + * + * @return void + */ + public function down() + { + Schema::table('bookings', function (Blueprint $table) { + // + }); + } +} diff --git a/resources/assets/js/pages/booking/uploadUserBankSlip.vue b/resources/assets/js/pages/booking/uploadUserBankSlip.vue index 534c66c3..e1528abf 100644 --- a/resources/assets/js/pages/booking/uploadUserBankSlip.vue +++ b/resources/assets/js/pages/booking/uploadUserBankSlip.vue @@ -44,6 +44,7 @@
Date: Tue, 31 Jul 2018 13:54:19 +0800 Subject: [PATCH 4/5] fix upload user bankslip with indicator and allow single imageo nly --- .../js/pages/booking/uploadUserBankSlip.vue | 585 ++++++++++-------- 1 file changed, 327 insertions(+), 258 deletions(-) diff --git a/resources/assets/js/pages/booking/uploadUserBankSlip.vue b/resources/assets/js/pages/booking/uploadUserBankSlip.vue index e1528abf..89ac48a9 100644 --- a/resources/assets/js/pages/booking/uploadUserBankSlip.vue +++ b/resources/assets/js/pages/booking/uploadUserBankSlip.vue @@ -1,101 +1,117 @@ + \ No newline at end of file From 2cc5c5074587aecceb158bc71ff83750afaaa7a9 Mon Sep 17 00:00:00 2001 From: Jack Goh Date: Tue, 31 Jul 2018 14:28:16 +0800 Subject: [PATCH 5/5] removed accept file type to fix no action can be perform in wechat inapp browser --- resources/assets/js/pages/booking/uploadUserBankSlip.vue | 1 - 1 file changed, 1 deletion(-) diff --git a/resources/assets/js/pages/booking/uploadUserBankSlip.vue b/resources/assets/js/pages/booking/uploadUserBankSlip.vue index 89ac48a9..4f640558 100644 --- a/resources/assets/js/pages/booking/uploadUserBankSlip.vue +++ b/resources/assets/js/pages/booking/uploadUserBankSlip.vue @@ -58,7 +58,6 @@ -->