From f36015e762ac8bfc0b9e7fa0790b9ce1674cf64f Mon Sep 17 00:00:00 2001 From: Kawlll Maxso Date: Mon, 15 Apr 2019 18:44:53 +0800 Subject: [PATCH 1/6] Fix for list order history api --- .../Orders/Services/ListsOrderHistory.php | 29 +++++++++---------- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/app/Classes/Modules/Orders/Services/ListsOrderHistory.php b/app/Classes/Modules/Orders/Services/ListsOrderHistory.php index bf653f2..b8d2283 100644 --- a/app/Classes/Modules/Orders/Services/ListsOrderHistory.php +++ b/app/Classes/Modules/Orders/Services/ListsOrderHistory.php @@ -72,26 +72,25 @@ class ListsOrderHistory $history->push(['date' => $step->updated_at->format('d-m-Y H:i'), 'description' => 'Out for delivery']); break; } - } - - if($order->current_step === Constants::ORDER_SHIPPING_STEP){ - $shippingArrangment = $order->shippingArrangement()->first(); - if($shippingArrangment){ - $shippingSchedules = $shippingArrangment->shippingSchedule()->get(); - foreach ($shippingSchedules as $schedule){ - if($schedule->status === 2){ - $customeIssue = CustomIssues::where('schedule_id', $schedule->id)->first(); - if($customeIssue !== null){ - $history->push(['date' => $step->updated_at->format('d-m-Y H:i'), 'description' => '[ETD: '.$schedule->ETD.', ETA: '.$schedule->ETA.'] Shipping Schedule failed due to: '.$customeIssue->remark]); + if($order->current_step === Constants::ORDER_SHIPPING_STEP){ + $shippingArrangment = $order->shippingArrangement()->first(); + if($shippingArrangment){ + $shippingSchedules = $shippingArrangment->shippingSchedule()->get(); + foreach ($shippingSchedules as $schedule){ + if($schedule->status === 2){ + $customeIssue = CustomIssues::where('schedule_id', $schedule->id)->first(); + if($customeIssue !== null){ + $history->push(['date' => $step->updated_at->format('d-m-Y H:i'), 'description' => '[ETD: '.$schedule->ETD.', ETA: '.$schedule->ETA.'] Shipping Schedule failed due to: '.$customeIssue->remark]); + } else { + $history->push(['date' => $step->updated_at->format('d-m-Y H:i'), 'description' => '[ETD: '.$schedule->ETD.', ETA: '.$schedule->ETA.'] Shipping Schedule failed']); + } } else { - $history->push(['date' => $step->updated_at->format('d-m-Y H:i'), 'description' => '[ETD: '.$schedule->ETD.', ETA: '.$schedule->ETA.'] Shipping Schedule failed']); + $history->push(['date' => $step->updated_at->format('d-m-Y H:i'), 'description' => '[ETD: '.$schedule->ETD.', ETA: '.$schedule->ETA.'] Your Order has been scheduled for shipping ']); } - } else { - $history->push(['date' => $step->updated_at->format('d-m-Y H:i'), 'description' => '[ETD: '.$schedule->ETD.', ETA: '.$schedule->ETA.'] Your Order has been scheduled for shipping ']); } } - } + } } if($complete){ From ac4cae37caecf7278e1c6b9ca917c6a59004eb14 Mon Sep 17 00:00:00 2001 From: ayen Date: Tue, 16 Apr 2019 03:12:41 +0000 Subject: [PATCH 2/6] Update ShippingStepComponenet.vue. fixing datepicker validation month logic --- .../order/elements/ShippingStepComponenet.vue | 22 ++++++++++++------- 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/resources/assets/vue/components/order/elements/ShippingStepComponenet.vue b/resources/assets/vue/components/order/elements/ShippingStepComponenet.vue index d415d32..88af457 100644 --- a/resources/assets/vue/components/order/elements/ShippingStepComponenet.vue +++ b/resources/assets/vue/components/order/elements/ShippingStepComponenet.vue @@ -140,10 +140,10 @@ + title="Arrived To Port" + :message="'Are you sure this order has arrived to port?'" + type="shippingComplete" + v-on:confirm="completeShipping()"> @@ -179,6 +179,7 @@ } }, mounted: function() { + this.validateMethod(); this.dataValidation(); }, created(){ @@ -189,6 +190,11 @@ } }, methods: { + validateMethod() { + $.validator.addMethod("minDate", function(value, element, params) { + return (moment(value, "DD-MM-YYYY") > moment(params, "DD-MM-YYYY")) + }); + }, dataValidation() { $(this.$el).find('.shippingForm').validate({ rules: { @@ -199,7 +205,7 @@ }, messages: { ETA: { - min : 'ETA must be greater than ETD' + minDate : 'ETA must be greater than ETD' } }, errorPlacement: function ( error, element ) { @@ -227,7 +233,7 @@ }, messages: { ETA: { - min : 'ETA must be greater than ETD' + minDate : 'ETA must be greater than ETD' } }, errorPlacement: function ( error, element ) { @@ -252,7 +258,7 @@ $(this.$el).find('.shippingForm').valid(); this.shippingArrangement.schedule.ETD = date; $(this.$el).find('.shippingForm .ETA').rules("add", { - min: moment(this.shippingArrangement.schedule.ETD, "DD-MM-YYYY").add(1, 'days').format('DD-MM-YYYY') + minDate: moment(this.shippingArrangement.schedule.ETD, "DD-MM-YYYY").add(1, 'days').format('DD-MM-YYYY') }) } @@ -269,7 +275,7 @@ $(this.$el).find('.rescheduleShipping').valid(); this.reschedule.ETD = date; $(this.$el).find('.rescheduleShipping .ETA').rules("add", { - min: moment(this.reschedule.ETD, "DD-MM-YYYY").add(1, 'days').format('DD-MM-YYYY') + minDate: moment(this.reschedule.ETD, "DD-MM-YYYY").add(1, 'days').format('DD-MM-YYYY') }) } From 266d737c9070ad4f90dbeb2f6efea330b227f218 Mon Sep 17 00:00:00 2001 From: hazim Date: Tue, 16 Apr 2019 11:38:03 +0800 Subject: [PATCH 3/6] Omair's order history list --- .../Orders/Services/ListsOrderHistory.php | 33 ++++++++++--------- 1 file changed, 17 insertions(+), 16 deletions(-) diff --git a/app/Classes/Modules/Orders/Services/ListsOrderHistory.php b/app/Classes/Modules/Orders/Services/ListsOrderHistory.php index b2e9beb..53b743b 100644 --- a/app/Classes/Modules/Orders/Services/ListsOrderHistory.php +++ b/app/Classes/Modules/Orders/Services/ListsOrderHistory.php @@ -29,8 +29,9 @@ class ListsOrderHistory foreach ($orderSteps as $step){ switch ($step->reference_id){ case Constants::ORDER_PROCESSING_STEP: - $warehouse = Warehouse::find($order->warehouse_id)->first(); - $history->push(['date' => $step->updated_at->format('d-m-Y H:i'), 'description' => $warehouse ? $warehouse->name.' confirmed as your order\'s warehouse' : ' Your order\'s warehouse has been confirmed']); + if($order->warehouse_id){ + $history->push(['date' => $step->updated_at->format('d-m-Y H:i'), 'description' => Warehouse::find($order->warehouse_id)->first()->name.' confirmed as your order\'s warehouse']); + } break; case Constants::ORDER_NO_WAREHOUSE_PENDING_SUPPLIER: $history->push(['date' => $step->updated_at->format('d-m-Y H:i'), 'description' => 'Your Order has been loaded into container']); @@ -45,14 +46,14 @@ class ListsOrderHistory $history->push(['date' => $step->updated_at->format('d-m-Y H:i'), 'description' => 'Invoice has been issued, waiting for shipping payment']); break; case Constants::ORDER_SHIPPING_STEP: - $shippingArrangment = $order->shippingArrangement()->first(); - if($shippingArrangment){ - $shippingSchedules = $shippingArrangment->shippingSchedule()->get(); + $shippingArrangement = $order->shippingArrangement()->first(); + if($shippingArrangement){ + $shippingSchedules = $shippingArrangement->shippingSchedule()->get(); foreach ($shippingSchedules as $schedule){ if($schedule->status === 2){ - $customeIssue = CustomIssues::where('schedule_id', $schedule->id)->first(); - if($customeIssue !== null){ - $history->push(['date' => $step->updated_at->format('d-m-Y H:i'), 'description' => '[ETD: '.$schedule->ETD.', ETA: '.$schedule->ETA.'] Shipping Schedule failed due to: '.$customeIssue->remark]); + $customIssue = CustomIssues::where('schedule_id', $schedule->id)->first(); + if($customIssue !== null){ + $history->push(['date' => $step->updated_at->format('d-m-Y H:i'), 'description' => '[ETD: '.$schedule->ETD.', ETA: '.$schedule->ETA.'] Shipping Schedule failed due to: '.$customIssue->remark]); } else { $history->push(['date' => $step->updated_at->format('d-m-Y H:i'), 'description' => '[ETD: '.$schedule->ETD.', ETA: '.$schedule->ETA.'] Shipping Schedule failed']); } @@ -77,19 +78,19 @@ class ListsOrderHistory } if($order->current_step === Constants::ORDER_SHIPPING_STEP){ - $shippingArrangment = $order->shippingArrangement()->first(); - if($shippingArrangment){ - $shippingSchedules = $shippingArrangment->shippingSchedule()->get(); + $shippingArrangement = $order->shippingArrangement()->first(); + if($shippingArrangement){ + $shippingSchedules = $shippingArrangement->shippingSchedule()->get(); foreach ($shippingSchedules as $schedule){ if($schedule->status === 2){ - $customeIssue = CustomIssues::where('schedule_id', $schedule->id)->first(); - if($customeIssue !== null){ - $history->push(['date' => $shippingSchedules->updated_at->format('d-m-Y H:i'), 'description' => '[ETD: '.$schedule->ETD.', ETA: '.$schedule->ETA.'] Shipping Schedule failed due to: '.$customeIssue->remark]); + $customIssue = CustomIssues::where('schedule_id', $schedule->id)->first(); + if($customIssue !== null){ + $history->push(['date' => $schedule->updated_at->format('d-m-Y H:i'), 'description' => '[ETD: '.$schedule->ETD.', ETA: '.$schedule->ETA.'] Shipping Schedule failed due to: '.$customIssue->remark]); } else { - $history->push(['date' => $shippingSchedules->updated_at->format('d-m-Y H:i'), 'description' => '[ETD: '.$schedule->ETD.', ETA: '.$schedule->ETA.'] Shipping Schedule failed']); + $history->push(['date' => $schedule->updated_at->format('d-m-Y H:i'), 'description' => '[ETD: '.$schedule->ETD.', ETA: '.$schedule->ETA.'] Shipping Schedule failed']); } } else { - $history->push(['date' => $shippingSchedules->updated_at->format('d-m-Y H:i'), 'description' => '[ETD: '.$schedule->ETD.', ETA: '.$schedule->ETA.'] Your Order has been scheduled for shipping ']); + $history->push(['date' => $schedule->updated_at->format('d-m-Y H:i'), 'description' => '[ETD: '.$schedule->ETD.', ETA: '.$schedule->ETA.'] Your Order has been scheduled for shipping ']); } } } From cd462b777c68306bab9a288e8b5b6ea5487a0a00 Mon Sep 17 00:00:00 2001 From: omair saleh Date: Tue, 16 Apr 2019 03:43:39 +0000 Subject: [PATCH 4/6] Update ShippingStepComponenet.vue --- .../components/order/elements/ShippingStepComponenet.vue | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/resources/assets/vue/components/order/elements/ShippingStepComponenet.vue b/resources/assets/vue/components/order/elements/ShippingStepComponenet.vue index 88af457..88f0b08 100644 --- a/resources/assets/vue/components/order/elements/ShippingStepComponenet.vue +++ b/resources/assets/vue/components/order/elements/ShippingStepComponenet.vue @@ -140,10 +140,10 @@ + title="Arrived To Port" + :message="'Are you sure this order has arrived to port?'" + type="shippingComplete" + v-on:confirm="completeShipping()"> From 6686451d73b5512db8f23c1e629b4dd279b3e797 Mon Sep 17 00:00:00 2001 From: Kawlll Maxso Date: Mon, 22 Apr 2019 10:22:07 +0800 Subject: [PATCH 5/6] Notification --- .../common/NotificationComponent.vue | 18 ++-- .../forms/AddressBookFormComponent.vue | 13 ++- .../company/forms/CompanyFormComponent.vue | 16 ++-- .../contact/forms/ContactFormComponent.vue | 11 ++- .../order/elements/ArrivalStepComponenet.vue | 10 ++ .../order/elements/ConfirmOrderComponent.vue | 10 ++ .../order/elements/DeliveryStepComponenet.vue | 9 ++ .../order/elements/PackingStepComponenet.vue | 17 ++++ .../order/elements/ReceiveStepComponenet.vue | 9 ++ .../order/elements/ShippingStepComponenet.vue | 27 +++++- .../SupplierPackingStepComponenet.vue | 10 ++ .../elements/UnpackingStepComponenet.vue | 9 ++ .../order/forms/OrderFormComponent.vue | 8 ++ .../forms/WarehouseFormComponent.vue | 11 +++ resources/assets/vue/constant/notification.js | 92 +++++++++++++++++++ 15 files changed, 252 insertions(+), 18 deletions(-) create mode 100644 resources/assets/vue/constant/notification.js diff --git a/resources/assets/vue/components/common/NotificationComponent.vue b/resources/assets/vue/components/common/NotificationComponent.vue index 0f34dae..0a25cf6 100644 --- a/resources/assets/vue/components/common/NotificationComponent.vue +++ b/resources/assets/vue/components/common/NotificationComponent.vue @@ -1,11 +1,13 @@