From 52c1093d2d017f629b534a807cfcb3631abfada8 Mon Sep 17 00:00:00 2001
From: mhmj <mhazimmdjais@gmail.com>
Date: Tue, 28 May 2019 14:46:27 +0800
Subject: [PATCH] Order-Change-Address

---
 .../Orders/UpdateOrderAddressLogic.php        | 12 +-----
 .../DataTransferObjects/AddressObject.php     | 37 -------------------
 .../Orders/Services/UpdatesOrderAddress.php   | 11 +-----
 .../Orders/UpdateOrderAddressController.php   |  7 ----
 routes/api.php                                |  2 +-
 5 files changed, 5 insertions(+), 64 deletions(-)
 delete mode 100644 app/Classes/Modules/Orders/DataTransferObjects/AddressObject.php

diff --git a/app/Classes/Modules/ControllersLogic/Orders/UpdateOrderAddressLogic.php b/app/Classes/Modules/ControllersLogic/Orders/UpdateOrderAddressLogic.php
index c7eba21..d72b6bd 100644
--- a/app/Classes/Modules/ControllersLogic/Orders/UpdateOrderAddressLogic.php
+++ b/app/Classes/Modules/ControllersLogic/Orders/UpdateOrderAddressLogic.php
@@ -1,14 +1,7 @@
 <?php
-/**
- * Created by PhpStorm.
- * User: mhmj
- * Date: 28/05/2019
- * Time: 10:51 AM
- */
 
 namespace App\Classes\Modules\ControllersLogic\Orders;
 
-
 use App\Classes\Modules\ControllerLogic\Exceptions\InternalServerErrorException;
 use App\Classes\Modules\Orders\DataTransferObjects\AddressObject;
 use App\Classes\Modules\Orders\Services\UpdatesOrderAddress;
@@ -32,10 +25,9 @@ class UpdateOrderAddressLogic
 
     public function execute(string $orderId, Request $request){
         try{
-            $addressObject = new AddressObject($request->address_id);
-            return $this->UpdatesOrderAddress->execute($orderId,$addressObject);
 
-            return new JsonResponse([],HttpStatus::RESOURCE_CREATED);
+            return $this->UpdatesOrderAddress->execute($orderId,$request->address_id);
+            return new JsonResponse([],HttpStatus::REQUEST_ACCEPTED);
 
         } catch (\Exception $exception) {
             throw new InternalServerErrorException("Failed to update address because{$exception->getMessage()}");
diff --git a/app/Classes/Modules/Orders/DataTransferObjects/AddressObject.php b/app/Classes/Modules/Orders/DataTransferObjects/AddressObject.php
deleted file mode 100644
index 7559e6b..0000000
--- a/app/Classes/Modules/Orders/DataTransferObjects/AddressObject.php
+++ /dev/null
@@ -1,37 +0,0 @@
-<?php
-/**
- * Created by PhpStorm.
- * User: mhmj
- * Date: 28/05/2019
- * Time: 11:11 AM
- */
-
-namespace App\Classes\Modules\Orders\DataTransferObjects;
-
-
-class AddressObject
-{
-    /** @var  string */
-    private $addressId;
-
-    /**
-     * AddressObject constructor.
-     * @param string $addressId
-     */
-    public function __construct(string $addressId)
-    {
-        $this->addressId = $addressId;
-    }
-
-    /**
-     * @return string
-     */
-    public function getAddressId(): string
-    {
-        return $this->addressId;
-    }
-
-
-
-
-}
\ No newline at end of file
diff --git a/app/Classes/Modules/Orders/Services/UpdatesOrderAddress.php b/app/Classes/Modules/Orders/Services/UpdatesOrderAddress.php
index 1091738..3a3750c 100644
--- a/app/Classes/Modules/Orders/Services/UpdatesOrderAddress.php
+++ b/app/Classes/Modules/Orders/Services/UpdatesOrderAddress.php
@@ -1,14 +1,7 @@
 <?php
-/**
- * Created by PhpStorm.
- * User: mhmj
- * Date: 28/05/2019
- * Time: 11:00 AM
- */
 
 namespace App\Classes\Modules\Orders\Services;
 
-
 use App\Classes\Modules\ControllerLogic\Exceptions\InternalServerErrorException;
 use App\Classes\Modules\Orders\DataTransferObjects\AddressObject;
 use App\Classes\ValueObjects\Constants\HttpStatus;
@@ -30,11 +23,11 @@ class UpdatesOrderAddress
     }
 
 
-    public function execute(string $orderId,AddressObject $addressObject){
+    public function execute(string $orderId,string $addressId){
         try{
 
             $repository = $this->repository->findOrFail($orderId);
-            $repository->address_id = $addressObject->getAddressId();
+            $repository->address_id = $addressId;
             $repository->save();
             return new JsonResponse([],HttpStatus::OK);
 
diff --git a/app/Http/Controllers/Orders/UpdateOrderAddressController.php b/app/Http/Controllers/Orders/UpdateOrderAddressController.php
index 78f79ea..4ccf670 100644
--- a/app/Http/Controllers/Orders/UpdateOrderAddressController.php
+++ b/app/Http/Controllers/Orders/UpdateOrderAddressController.php
@@ -1,14 +1,7 @@
 <?php
-/**
- * Created by PhpStorm.
- * User: mhmj
- * Date: 28/05/2019
- * Time: 10:51 AM
- */
 
 namespace App\Http\Controllers\Orders;
 
-
 use App\Classes\Modules\ControllersLogic\Orders\UpdateOrderAddressLogic;
 use Illuminate\Http\Request;
 
diff --git a/routes/api.php b/routes/api.php
index b163f04..df8b6e0 100644
--- a/routes/api.php
+++ b/routes/api.php
@@ -136,7 +136,7 @@ Route::group(['middleware' => 'api', 'prefix' => 'v1', 'as' => 'api.'], function
 
         Route::post('/bulk-receive-notes', 'BulkReceiveNotesController@create')->name('bulk.receive.update');
 
-        Route::post('/{orderId}/address','UpdateOrderAddressController@update')->name('address.update');
+        Route::post('/{orderId}/address','UpdateOrderAddressController@update')->name('address.order.update');
 
     });