From 55f7ce9c248aa55cc77ee852f2834ab6a41e00af Mon Sep 17 00:00:00 2001 From: Omair Saleh Date: Fri, 12 Apr 2019 22:16:53 +0800 Subject: [PATCH] large changes --- app/Classes/Modules/Orders/Services/ListsOrderHistory.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/Classes/Modules/Orders/Services/ListsOrderHistory.php b/app/Classes/Modules/Orders/Services/ListsOrderHistory.php index 53ec1e8..e3c64bd 100644 --- a/app/Classes/Modules/Orders/Services/ListsOrderHistory.php +++ b/app/Classes/Modules/Orders/Services/ListsOrderHistory.php @@ -48,7 +48,7 @@ class ListsOrderHistory foreach ($shippingSchedules as $schedule){ if($schedule->status === "2"){ $customeIssue = CustomIssues::where('schedule_id', $schedule->id)->first(); - if($customeIssue){ + if($customeIssue !== null){ $history->push(['date' => $step->updated_at->format('d-m-Y H:i'), 'description' => '[ETD: '.$schedule->ETD.', ETA: '.$schedule->ETA.'] Shipping Schedule failed due to: '.$customeIssue->remark]); } else { $history->push(['date' => $step->updated_at->format('d-m-Y H:i'), 'description' => '[ETD: '.$schedule->ETD.', ETA: '.$schedule->ETA.'] Shipping Schedule failed']); @@ -80,7 +80,7 @@ class ListsOrderHistory foreach ($shippingSchedules as $schedule){ if($schedule->status === "2"){ $customeIssue = CustomIssues::where('schedule_id', $schedule->id)->firstOrFail(); - if($customeIssue){ + if($customeIssue !== null){ $history->push(['date' => $step->updated_at->format('d-m-Y H:i'), 'description' => '[ETD: '.$schedule->ETD.', ETA: '.$schedule->ETA.'] Shipping Schedule failed due to: '.$customeIssue->remark]); } else { $history->push(['date' => $step->updated_at->format('d-m-Y H:i'), 'description' => '[ETD: '.$schedule->ETD.', ETA: '.$schedule->ETA.'] Shipping Schedule failed']);