download billing documents

app/Classes/Modules/Bookings/ControllersLogic/DownloadBookingDocumentLogic.php

@@ -3,7 +3,6 @@
 namespace App\Classes\Modules\Bookings\ControllersLogic;
 
 
-use Illuminate\Support\Facades\Response;
 use ZipArchive;
 use Carbon\Carbon;
 use App\Models\User;
@@ -24,7 +23,7 @@ class DownloadBookingDocumentLogic
 
     /**
      * @param Request $request
-     * @return \Symfony\Component\HttpFoundation\BinaryFileResponse
+     * @return void
      * @throws MalformedRequestException
      */
     public function execute(Request $request)
@@ -48,9 +47,12 @@ class DownloadBookingDocumentLogic
                 $zip->addFile(Storage::disk('documents')->path($file->file->file_info->original->file), $booking->created_at->format('d_m_Y') . '_' . $booking->marking . '.pdf');
             }
 
-            $zip->close();
+            if ($zip->close() === false) {
+                exit("Error creating ZIP file");
+            };
 
-            return Response::download(File::get($attachment), $request->input('type').'.zip', ['Content-Type: application/zip']);
+            readfile($attachment);
+            unlink($attachment);
 
         }
     }