A minor fix to not allow non-admin user to see admin data by navigating to the url /payment-and-billing-2

app/Http/Resources/GroupForOrderV2Resource.php

@@ -26,7 +26,7 @@ class GroupForOrderV2Resource extends JsonResource
             'original_currency' => new CurrencyResource($this->original_currency),
             'issuer_name' => $this->issuerCompany->name,
             'issuer_id' => $this->issuerCompany->id,
-            'amount' => (float) $this->amount, //cief todo: 58
+            'amount' => (float) $this->amount,
             'service_charge' => (float) $this->amount,
             'currency' => new CurrencyResource($this->currency),
             'created_at' => Carbon::parse($this->created_at)->format('d-m-Y h:i:s A'),

app/Http/Resources/TransactionResource.php

@@ -52,7 +52,7 @@ class TransactionResource extends JsonResource
             'documents' => $groupTransactions ? DocumentResource::collection($this->documents->where('status', ApprovalStatus::PENDING_VERIFICATION)) : DocumentResource::collection($this->documents),
             'type' => (int) $this->type,
             'bill_no' => $this->bill_no,
-            'amount' => (double) $this->amount, //cief todo: 58
+            'amount' => (double) $this->amount,
             'payment_method' => (int) $this->payment_method,
             'payment_reference' => $this->payment_reference,
             'outstanding' => (double) $this->amount - ($this->transactions()->where('type', TransactionType::PAYMENT)->whereIn('status', [ApprovalStatus::APPROVED, ApprovalStatus::COMPLETED])->sum('amount')),

app/Http/Resources/TransactionWithStorageResource.php

@@ -59,7 +59,7 @@ class TransactionWithStorageResource extends JsonResource
         if ($ts) {
             $paymentTransaction = Transaction::where('payment_reference',  $ts->reference)->whereIn('status', [ApprovalStatus::PENDING_SUBMISSION])->first();
             if($paymentTransaction){
-                $groupTotalAmount = (double) $this->amount; //cief todo: 58
+                $groupTotalAmount = (double) $this->amount;
 
                 foreach ($group_payment_history as $key => $value) {
                     if ($value->id === $ts->id && $value->reference === $ts->reference) {
@@ -88,10 +88,10 @@ class TransactionWithStorageResource extends JsonResource
             'documents' => $groupTransactions ? DocumentResource::collection($this->documents->where('status', ApprovalStatus::PENDING_VERIFICATION)) : DocumentResource::collection($this->documents),
             'type' => (int) $this->type,
             'bill_no' => $this->bill_no,
-            'amount' => (double) $this->amount, //cief todo: 58
+            'amount' => (double) $this->amount,
             'payment_method' => (int) $this->payment_method,
             'payment_reference' => $this->payment_reference,
-            'outstanding' => (double) $this->amount - ($this->transactions()->where('type', TransactionType::PAYMENT)->whereIn('status', [ApprovalStatus::APPROVED, ApprovalStatus::COMPLETED])->sum('amount')), //cief todo: 58
+            'outstanding' => (double) $this->amount - ($this->transactions()->where('type', TransactionType::PAYMENT)->whereIn('status', [ApprovalStatus::APPROVED, ApprovalStatus::COMPLETED])->sum('amount')),
             'floating' => $group_payment_attempts ? $groupTotalAmount : (double) $this->transactions()->where('type', TransactionType::PAYMENT)->whereIn('status', [ApprovalStatus::PENDING_SUBMISSION, ApprovalStatus::PENDING_VERIFICATION])->sum('amount'),
             'service_charge' => (double) $this->service_charge,
             'tax' => (double) $this->tax,

resources/assets/vue/components/general/elements/ListPollingComponent.vue

@@ -74,9 +74,6 @@
         data(){
             return {
                 filters: this.options,
-                pollingInterval: null,
-                isPolling: false,
-                isFetchingResult: false,
                 isLoading: false,
             }
         },
@@ -87,13 +84,26 @@
         computed: {
             pendingList () {
                 return this.$store.getters.isInCompleteQueue(this.section);
-            }
+            },
+            getJob() {
+                return this.$store.getters.getJob(this.section);
+            },
+            getJobAttemptCount() {
+                return this.$store.getters.getJobAttemptCount(this.section);
+            },
         },
         watch: {
             pendingList(inComplete){
                 if(inComplete){
                     this.fetchList();
                 }
+            },
+            getJobAttemptCount(newValue, oldValue) {
+                // console.log('Old value:',  JSON.stringify(oldValue));
+                // console.log('New value:',  JSON.stringify(newValue));
+                if(this.getJob){
+                    this.fetchJobResult(this.getJob.isLastAttempt);
+                }
             }
         },
         methods: {
@@ -101,7 +111,7 @@
                 let listDecorators = this.$store.getters.getListDetails(this.section);
                 let url = this.endpoint + '?page=' + listDecorators.page + '&filters=' + JSON.stringify(listDecorators.filters);
                 this.isLoading = true;
-                this.submitJob(url);
+                this.$store.dispatch('submitJobRequest', {'url': url, 'name': this.section});
             },
             successHandler(response){
                 let result = JSON.parse(response.payload.data.result);
@@ -118,83 +128,21 @@
                     to: result.meta.to,
                     total: result.meta.total
                 };
-
-                this.stopPolling();
                 this.$store.dispatch('completeList', {'name': this.section, 'data': result.data});
+                this.$store.dispatch('stopPollingJobResultByJobId', {'jobId': this.getJob.jobId});
                 this.$refs.pagination.makePagination(result.meta, result.links);
                 this.isLoading = false;
             },
             errorHandler(error){
-                this.isFetchingResult = false;
-                this.isPolling = false;
+                // console.log("Error: " + JSON.stringify(error));
+                this.$store.dispatch('updatePollingJobResultByJobId', {'jobId': this.getJob.jobId, 'isPolling': false, 'isFetchingResult': false });
             },
-            startPolling(jobId, maxAttempts = 8) {
-                let attempts = 0;
-                let interval = 10000; // Initial interval
-
-                const resetPollingInterval = (customInterval) => {
-                    this.pollingInterval = setInterval(pollJobResult, customInterval);
-                };
-
-                const pollJobResult = () => {
-                    if (this.isPolling || this.isFetchingResult) {
-                        return;
-                    }
-                    this.isPolling = true;
-
-                    attempts++;
-                    if(attempts === 1){
-                        this.stopPolling();
-                        resetPollingInterval(5000);
-                    }
-
-                    if (attempts > maxAttempts) {
-                        this.stopPolling();
-                        this.isLoading = false;
-                        console.log(`Reached maximum attempts (${maxAttempts}). Polling stopped.`);
-                        return;
-                    }
-
-                    if(attempts === maxAttempts){
-                        this.fetchJobResult(jobId, true);
-                    }
-                    else{
-                        this.fetchJobResult(jobId);
-                    }
-                };
-
-                // pollJobResult();  // Initial call
-                this.pollingInterval = setInterval(pollJobResult, interval);
-            },
-            stopPolling() {
-                clearInterval(this.pollingInterval);
-                this.pollingInterval = null;
-                this.isPolling = false;
-                this.isFetchingResult = false;
-            },
-            submitJob(url){
+            fetchJobResult(isLastAttempt = false) {
+                this.$store.dispatch('updatePollingJobResultByJobId', {'jobId': this.getJob.jobId, 'isFetchingResult': true });
                 try {
-                    this.$store.dispatch('crudRequestV2', {endpoint: url, method: 'get'}).then(response => {
-                        let success = response.ok;
-                        response.json().then(response => {
-                            if(!success){return;}
-                            let jobId = response.payload.data.job_id;
-                            if(jobId){
-                                this.startPolling(jobId);
-                            }
-                        });
-                    })
-                } catch (error) {
-                    console.error('Error submitJob', error);
-                }
-            },
-            fetchJobResult(jobId, isLastAttempt = false) {
-                // console.log('fetchJobResult: ', jobId);
-                this.isFetchingResult = true;
-                try {
-                    let anotherEndpoint = route('api.job.fetch', jobId);
+                    let anotherEndpoint = route('api.job.fetch', this.getJob.jobId);
                     if(isLastAttempt){
-                        anotherEndpoint = route('api.job.fetch.last.attempt', jobId, isLastAttempt);
+                        anotherEndpoint = route('api.job.fetch.last.attempt', this.getJob.jobId, isLastAttempt);
                     }
                     this.poll(anotherEndpoint, 'get', this.section, false, false); //cief todo: Uncaught (in promise) null
                 } catch (error) {

resources/assets/vue/vuex/modules/jobPolling.js

@@ -0,0 +1,134 @@
+
+const state = {
+    pollingJobResults: []
+};
+
+export default {
+    state,
+    getters: {
+        getJob: (state) => (name) => {
+            return state.pollingJobResults.find(item => item.name === name);;
+        },
+        getJobAttemptCount: (state) => (name) => {
+            let job = state.pollingJobResults.find(item => item.name === name);
+            return job ? job.pollingAttemptsCount : 0;
+        },
+    },
+    mutations: {
+        ADD_POLLING_JOB_RESULT(state, {jobId, name, pollingAttemptsCount, isPolling, isFetchingResult, maxAttempts, pollJobResult, interval}) {
+            let intervalId = setInterval(() => {
+                if (pollJobResult) {
+                    pollJobResult(state);
+                }
+            }, interval);
+            state.pollingJobResults.push({ jobId, name, pollingAttemptsCount, isPolling, isFetchingResult, maxAttempts, intervalId});
+        },
+        UPDATE_POLLING_JOB_RESULT(state, { jobId, pollingAttemptsCount, isPolling, isFetchingResult, isLastAttempt}) {
+            const index = state.pollingJobResults.findIndex(s => s.jobId === jobId);
+            if (index !== -1) {
+              const updatedPollingJobResults = [...state.pollingJobResults];
+              updatedPollingJobResults[index] = { ...updatedPollingJobResults[index],
+                jobId,
+                pollingAttemptsCount: pollingAttemptsCount !== undefined ? pollingAttemptsCount : updatedPollingJobResults[index].pollingAttemptsCount,
+                isPolling: isPolling !== undefined ? isPolling : updatedPollingJobResults[index].isPolling,
+                isFetchingResult: isFetchingResult !== undefined ? isFetchingResult : updatedPollingJobResults[index].isFetchingResult,
+                isLastAttempt: isLastAttempt !== undefined ? isLastAttempt : updatedPollingJobResults[index].isLastAttempt,
+              };
+              state.pollingJobResults = updatedPollingJobResults;
+            }
+        },
+        REMOVE_POLLING_JOB_RESULT_BY_JOBID(state, jobId) {
+            const index = state.pollingJobResults.findIndex(s => s.jobId === jobId);
+            if (index !== -1) {
+              clearInterval(state.pollingJobResults[index].intervalId);
+              state.pollingJobResults.splice(index, 1);
+            }
+        },
+        // REMOVE_POLLING_JOB_RESULT_BY_JOBID_2(state, jobId) {
+        //     const index = state.pollingJobResults.findIndex(s => s.jobId === jobId);
+        //     if (index !== -1) {
+        //       clearInterval(state.pollingJobResults[index].intervalId);
+        //       //state.pollingJobResults.splice(index, 1);
+        //     }
+        // },
+        REMOVE_POLLING_JOB_RESULT_BY_NAME(state, name) {
+            const index = state.pollingJobResults.findIndex(s => s.name === name);
+            if (index !== -1) {
+              clearInterval(state.pollingJobResults[index].intervalId);
+              state.pollingJobResults.splice(index, 1);
+            }
+        },
+    },
+    actions: {
+        submitJobRequest({ dispatch }, { url, name }){
+            dispatch('crudRequestV2', {
+                endpoint: url,
+                method: 'get',
+
+            }).then(response => {
+                let success = response.ok;
+                response.json().then(response => {
+                    if(!success){return;}
+                    let jobId = response.payload.data.job_id;
+                    if(jobId){
+                        let pollingAttemptsCount = 0;
+                        dispatch('startPolling', { jobId, name, pollingAttemptsCount });
+                    }
+                });
+            })
+        },
+
+        stopPollingJobResultByJobId({ commit }, { jobId }){
+            commit('REMOVE_POLLING_JOB_RESULT_BY_JOBID', jobId);
+        },
+
+        stopPollingJobResultByName({ commit }, { name }){
+            commit('REMOVE_POLLING_JOB_RESULT_BY_NAME', name);
+        },
+
+        startPolling({ state, commit, dispatch }, { jobId, name, pollingAttemptsCount, maxAttempts = 8}) {
+            let interval = 10000;
+
+            // console.log(`startPolling jobId: ${jobId}, pollingAttemptsCount: ${pollingAttemptsCount}, name: ${name}`);
+
+            const pollJobResult = (state) => {
+                //console.log(`MONITOR state ${JSON.stringify(state)}`);
+                const index = state.pollingJobResults.findIndex(s => s.jobId === jobId);
+                if (index !== -1) {
+                    pollingAttemptsCount = state.pollingJobResults[index].pollingAttemptsCount;
+                    if (state.pollingJobResults[index].isPolling || state.pollingJobResults[index].isFetchingResult) {
+                        return;
+                    }
+                }
+                else{
+                    return;
+                }
+
+                pollingAttemptsCount++;
+                if(pollingAttemptsCount === 1){
+                    commit("REMOVE_POLLING_JOB_RESULT_BY_JOBID", jobId );
+                    commit("ADD_POLLING_JOB_RESULT", { jobId, name, pollingAttemptsCount, isPolling: false, isFetchingResult: false, maxAttempts, pollJobResult, interval: 5000});
+                }
+
+                if (pollingAttemptsCount > maxAttempts) {
+                    //console.log(`Reached maximum attempts (${maxAttempts}). Polling stopped.`);
+                    commit("REMOVE_POLLING_JOB_RESULT_BY_JOBID", jobId );
+                    return;
+                }
+
+                if(pollingAttemptsCount === maxAttempts){
+                    commit('UPDATE_POLLING_JOB_RESULT', { jobId, pollingAttemptsCount, isPolling: true, isFetchingResult: false, isLastAttempt: true });
+                }
+                else{
+                    commit('UPDATE_POLLING_JOB_RESULT',  { jobId, pollingAttemptsCount, isPolling: true, isFetchingResult: false, isLastAttempt: false});
+                }
+            }
+            commit("ADD_POLLING_JOB_RESULT", { jobId, name, pollingAttemptsCount, isPolling: false, isFetchingResult: false, maxAttempts, pollJobResult, interval});
+
+        },
+
+        updatePollingJobResultByJobId({ commit }, { jobId, isPolling, isFetchingResult }){
+            commit('UPDATE_POLLING_JOB_RESULT', { jobId, isPolling, isFetchingResult });
+        }
+    }
+}

resources/assets/vue/vuex/store.js

@@ -7,6 +7,7 @@ import crudRequest from './modules/crudRequest'
 import crudRequestV2 from './modules/crudRequestV2'
 import authentication from './modules/authentication'
 import loadRequestQueue from './modules/loadRequestQueue'
+import jobPolling from './modules/jobPolling'
 
 Vue.use(Vuex);
 
@@ -18,6 +19,7 @@ export default new Vuex.Store({
         createNotification,
         crudRequest,
         crudRequestV2,
-        authentication
+        authentication,
+        jobPolling
     }
 })

resources/views/pages/paymentAndBilling2.blade.php

@@ -131,7 +131,7 @@
             </div>
         </div>
     </div>
-    <div class="row">
+    <div class="row" v-if="$store.getters.isAdmin">
         <div class="col">
             <admin-payments-billing-polling-section-component></admin-payments-billing-polling-section-component>
         </div>