cief/exchange-2.0
1
0
Fork 0
mirror of https://gitlab.com/CIEFWorldwideSdnBhd/exchange-2.0.git synced 2026-08-19 04:23:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix duplicated currency order booking for payments bug

Browse Source
This commit is contained in:
omair saleh
2021-07-13 20:21:22 +08:00
parent 036522ac17
commit fbb873ad7f
2 changed files with 2 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/Classes/Modules/Transactions/ControllersLogic/CreateSupplierTransactionLogic.php
+2 -6
View File
@@ -102,9 +102,7 @@ class CreateSupplierTransactionLogic extends AbstractControllerLogic
/** @var Transaction $payment */
$payment = $this->fetchesTransaction->execute(['id' => $payment['id']]);
if($payment->status !== ApprovalStatus::APPROVED) {
continue;
}
if($payment->status !== ApprovalStatus::APPROVED) continue;
$this->updatesTransactionStatus->execute($payment, ApprovalStatus::COMPLETED);
$billNumber = $this->generatesTransactionBillNumber->execute('SPLR-');
@@ -116,9 +114,7 @@ class CreateSupplierTransactionLogic extends AbstractControllerLogic
$transactions[] = $this->createsTransaction->execute($payment->booking, $object);
}
if(!count($transactions)){
return $this->response([]);
}
if(!count($transactions)) return $this->response([]);
$pdf = LaravelMpdf::loadView('pages.pdfs.currency_vendor_order', ['transactions' => $transactions, 'supplier' => $supplier]);
app/Http/Resources/TransactionResource.php
-3
View File
@@ -16,9 +16,6 @@ class TransactionResource extends JsonResource
*/
public function toArray($request)
{
if($this->booking === null) {
var_dump($this->booking_id);
}
return [
'id' => $this->id,
'booking' => new BookingResource($this->booking),